Use the new EncodeMapTask output in the SDK and stop using resources#2091
Merged
Use the new EncodeMapTask output in the SDK and stop using resources#2091
Conversation
fractalwrench
approved these changes
Apr 11, 2025
| "${EncodeSharedObjectFilesTask.NAME}${data.name.capitalizedString()}", | ||
| EncodeSharedObjectFilesTask::class.java | ||
| ) ?: return@transformClassesWith | ||
| project.afterEvaluate { |
Member
There was a problem hiding this comment.
What testing have we done around this to confirm that it works?
Contributor
Author
There was a problem hiding this comment.
Mostly the existing tests and debugging in different setups. Any particular test you think we should add? Tests do break without this 😅
Member
There was a problem hiding this comment.
I'm happy with that level of testing - the smali decompilation tests should be enough
ab9fc42 to
4b21e14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
==========================================
- Coverage 85.35% 85.33% -0.02%
==========================================
Files 470 470
Lines 10585 10578 -7
Branches 1564 1564
==========================================
- Hits 9035 9027 -8
Misses 870 870
- Partials 680 681 +1
🚀 New features to boost your workflow:
|
caef597 to
8f0dacb
Compare
4b21e14 to
c159046
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to keep this small but I had to replace many parts at once so it doesn't stop working.