Skip to content

Address PR comments for the new Encode task#2093

Merged
priettt merged 1 commit intomainfrom
priettt/encodeTaskComments
Apr 15, 2025
Merged

Address PR comments for the new Encode task#2093
priettt merged 1 commit intomainfrom
priettt/encodeTaskComments

Conversation

@priettt
Copy link
Copy Markdown
Contributor

@priettt priettt commented Apr 14, 2025

  • Rename encode task to make it more generic
  • Use Base64.wrap

@priettt priettt requested a review from a team as a code owner April 14, 2025 16:02
Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (27e9fe9) to head (d067935).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2093   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         470      470           
  Lines       10578    10578           
  Branches     1564     1564           
=======================================
  Hits         9029     9029           
  Misses        869      869           
  Partials      680      680           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@priettt priettt force-pushed the priettt/removeInjectTask branch from 6b75951 to 5b5a125 Compare April 15, 2025 15:08
Base automatically changed from priettt/removeInjectTask to main April 15, 2025 15:56
@priettt priettt force-pushed the priettt/encodeTaskComments branch from 70ab765 to d067935 Compare April 15, 2025 15:57
@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@priettt priettt merged commit 0e80dc0 into main Apr 15, 2025
10 checks passed
@priettt priettt deleted the priettt/encodeTaskComments branch April 15, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants