Skip to content

[Integration Branch] simplify bytecode instrumentation implementation#2103

Merged
bidetofevil merged 43 commits intomainfrom
integration/simplify-bytecode-instrumentation
Apr 29, 2025
Merged

[Integration Branch] simplify bytecode instrumentation implementation#2103
bidetofevil merged 43 commits intomainfrom
integration/simplify-bytecode-instrumentation

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Integration branch that contains changes to simplify bytecode instrumentation process.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Extract class visitor logic out of individual visitors
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (c60dc81) to head (fc7fab3).

Files with missing lines Patch % Lines
.../instrumentation/bytecode/FcmBytecodeEntrypoint.kt 0.00% 12 Missing ⚠️
...strumentation/bytecode/OkHttpBytecodeEntrypoint.kt 0.00% 12 Missing ⚠️
...dk/internal/instrumentation/bytecode/TouchEvent.kt 0.00% 12 Missing ⚠️
...trumentation/bytecode/OnClickBytecodeEntrypoint.kt 0.00% 1 Missing ⚠️
...entation/bytecode/OnLongClickBytecodeEntrypoint.kt 0.00% 1 Missing ⚠️
...tation/bytecode/WebViewClientBytecodeEntrypoint.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
+ Coverage   85.35%   85.50%   +0.15%     
==========================================
  Files         470      471       +1     
  Lines       10590    10571      -19     
  Branches     1565     1564       -1     
==========================================
  Hits         9039     9039              
+ Misses        870      851      -19     
  Partials      681      681              
Files with missing lines Coverage Δ
...l/capture/crumbs/PushNotificationCaptureService.kt 46.15% <ø> (ø)
...trumentation/bytecode/OnClickBytecodeEntrypoint.kt 0.00% <0.00%> (ø)
...entation/bytecode/OnLongClickBytecodeEntrypoint.kt 0.00% <0.00%> (ø)
...tation/bytecode/WebViewClientBytecodeEntrypoint.kt 0.00% <0.00%> (ø)
.../instrumentation/bytecode/FcmBytecodeEntrypoint.kt 0.00% <0.00%> (ø)
...strumentation/bytecode/OkHttpBytecodeEntrypoint.kt 0.00% <0.00%> (ø)
...dk/internal/instrumentation/bytecode/TouchEvent.kt 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Improve view instrumentation bytecode hooks
Alter push notification bytecode instrumentation hooks
Refactor OkHttp bytecode instrumentation hooks
Alter how operand stack indices are specified
Reduce parameters in bytecode instrumentation
Create class visit strategy hierarchy
Extract bytecode instrumentation features
@fractalwrench fractalwrench marked this pull request as ready for review April 29, 2025 10:23
@fractalwrench fractalwrench requested review from a team, bidetofevil and fnewberg as code owners April 29, 2025 10:23
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil merged commit af6e1d1 into main Apr 29, 2025
3 checks passed
@bidetofevil bidetofevil deleted the integration/simplify-bytecode-instrumentation branch April 29, 2025 14:57
@bidetofevil
Copy link
Copy Markdown
Contributor

Forced merged this because CI will never finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants