Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
fractalwrench
approved these changes
Apr 25, 2025
Member
fractalwrench
left a comment
There was a problem hiding this comment.
LGTM once failing tests on CI are addressed
| fun `an error is thrown when merge native libs task is not found`() { | ||
| // Given a project where merge native libs task is not registered | ||
| val projectTypeProvider = project.provider { ProjectType.UNITY } | ||
| val projectTypeProvider = project.provider { ProjectType.NATIVE } |
Member
There was a problem hiding this comment.
Is this change necessary?
Contributor
Author
There was a problem hiding this comment.
oh not at all, I thought I removed that change sorry
2c26280 to
5e24665
Compare
…epend on the outputs of merge[Variant]NativeLibs
5e24665 to
4cb22b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Using flatMap wires a dependency between the result and the outputs of the mergeNativeLibs task.
Using map doesn't do that, so I think that's why the provider was realized before the outputs where available, causing the exception:
Also use elements.map so we don't resolve the task output files too early.
Testing
Tested manually: now the example app builds correctly. We will add additional configuration cache testing later.