Use the draw complete time for missing activity init timestamps

[bidetofevil]

Goal

Activity init events might not be processed when the onDraw event fires because the latter jumps in front of the main thread handler queue. In these rare cases, use that timestamp in place of the activityInit timestamps.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[bidetofevil]

• Use the draw complete time for missing activity init timestamps #2121 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[bidetofevil]

This is the main change. Everything else is renaming the callback method to be more appropriate

[codecov]

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (71fe19c) to head (d04bb37).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...internal/capture/startup/AppStartupTraceEmitter.kt	88.88%	0 Missing and 2 partials ⚠️
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
+ Coverage   85.33%   85.35%   +0.01%     
==========================================
  Files         470      470              
  Lines       10578    10590      +12     
  Branches     1564     1565       +1     
==========================================
+ Hits         9027     9039      +12     
+ Misses        870      869       -1     
- Partials      681      682       +1     

Files with missing lines	Coverage Δ
...android/embracesdk/internal/ui/DrawEventEmitter.kt	62.50% <ø> (ø)
...bracesdk/internal/ui/HandlerMessageDrawDetector.kt	87.50% <100.00%> (ø)
...internal/capture/startup/AppStartupTraceEmitter.kt	86.05% <88.88%> (+0.34%)	⬆️
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt	42.85% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bidetofevil]

This is really to deal with the activityInit end event being missing, which is fired on onStarted() fires.

I am not sure if the init start event will ever be missing - for the Activity onCreate() callback to be processed after the draw, but I am handling this case just in case. After this is released, we can detect whether we have zero-duration child spans for activity init to see if it actually happens.

[fractalwrench]

LGTM

[bidetofevil]

Merge activity

• Apr 25, 10:31 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Apr 25, 10:32 AM EDT: Graphite rebased this pull request as part of a merge.
• Apr 25, 12:02 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 25, 12:20 PM EDT: @bidetofevil merged this pull request with Graphite.