Drive view click instrumentation via config#2125
Merged
fractalwrench merged 1 commit intointegration/simplify-bytecode-instrumentationfrom Apr 28, 2025
Merged
Drive view click instrumentation via config#2125fractalwrench merged 1 commit intointegration/simplify-bytecode-instrumentationfrom
fractalwrench merged 1 commit intointegration/simplify-bytecode-instrumentationfrom
Conversation
c9eea97 to
d62e34f
Compare
ba9a31f to
3524691
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## integration/simplify-bytecode-instrumentation #2125 +/- ##
==============================================================================
Coverage 85.49% 85.49%
==============================================================================
Files 471 471
Lines 10559 10559
Branches 1563 1563
==============================================================================
Hits 9027 9027
Misses 851 851
Partials 681 681 🚀 New features to boost your workflow:
|
Base automatically changed from
webview-config
to
integration/simplify-bytecode-instrumentation
April 25, 2025 16:01
3524691 to
5682486
Compare
bidetofevil
approved these changes
Apr 25, 2025
Contributor
bidetofevil
left a comment
There was a problem hiding this comment.
LGTM. If this worked before and doesn't work now, lets document it in case folks upgrade and stopped seeing these clicks.
f39c44f
into
integration/simplify-bytecode-instrumentation
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Drives the instrumentation for view clicks via a config file. This covers all the previous scenarios apart from one case where a Java lambda is supplied as below:
We could support this by adding an extra method visitor that specifically visits the bytecode this generates, but IMO it's likely not worth it given that few folks are writing Java, and that this will introduce complexity to our instrumentation - particularly knowing that our click instrumentation is imperfect already.
Testing
Updated existing test coverage.