Inline OkHttpNetworkService

[priettt]

Goal

Fixes error:

[EmbraceGradlePlugin] [OkHttpNetworkService] Exception occurred while making network request
java.lang.NullPointerException: Cannot invoke "okhttp3.OkHttpClient.newCall(okhttp3.Request)" because the return value of "io.embrace.android.gradle.plugin.network.OkHttpNetworkService.access$getClient$p(io.embrace.android.gradle.plugin.network.OkHttpNetworkService)" is null

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[bidetofevil]

If this is never reused, any reason why you don't just do the init in NdkUploadHandshake?

Or frankly, just extract that method out of the class and put in in this class? It was initially confusing what we are doing - initializing an object and then throwing it away, when it really is just a method call that internally needs an objet

[priettt]

Mostly because I thought it looked better than inlining 😅

I can change it if you have a strong preference, but we will probably be revisiting this later

[bidetofevil]

LGTM. Comment about why we need to create wrapper object for what is just method call where the networkService creation could just be inlined.