Fix eager resolution of unitySymbolsDir in getProjectType#2130
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
priettt
force-pushed
the
priettt/delayUnitySymbolsDirResolution
branch
from
480989c to
3cc9783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
getProjectTypewas wrapped in a provider, without considering its dependency onunitySymbolsDir. As a result, whenprojectTypewas realized, it would try to realizeunitySymbolsDireagerly, potentially resolving it before it was available.This change updates
getProjectTypeto useunitySymbolsDir.map, wiring the dependency and ensuring thatunitySymbolsDiris resolved only when needed.