Fix eager resolution of unitySymbolsDir in shared object file provider#2132
Merged
Fix eager resolution of unitySymbolsDir in shared object file provider#2132
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
priettt
force-pushed
the
priettt/fixUnitySharedObjectFileProvider
branch
from
26968c9 to
79aa685
Compare
priettt
force-pushed
the
priettt/fixUnitySharedObjectFileProvider
branch
from
79aa685 to
0aec9e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
getUnitySharedObjectFileswas accessingunitySymbolsDir(usingorNull) too early, which could mess with the build or with configuration cache if the symbols directory isn't ready yet.This change switches to using
flatMapsounitySymbolsDiris resolved lazily, only when needed.Also removed a test that didn't make sense, as the provider we receive can't be null.