Conversation
fractalwrench
approved these changes
Apr 28, 2025
priettt
force-pushed
the
priettt/fixCustomSymbolsDirDependencies
branch
from
0cf0a2c to
d3792d3
Compare
priettt
force-pushed
the
priettt/fixUnitySharedObjectFileProvider
branch
from
79aa685 to
0aec9e5
Compare
Base automatically changed from
priettt/fixUnitySharedObjectFileProvider
to
main
April 28, 2025 17:38
…sDirectory and Unity
priettt
force-pushed
the
priettt/fixCustomSymbolsDirDependencies
branch
from
d3792d3 to
81eab56
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
When using
mergeNativeLibsTask.flatMapat the start of the shared object files provider, we were enforcing a dependency on the mergeNativeLibs task for Unity projects and projects that set up a custom symbols directory.While I think most Unity projects will have that task, I'm not sure if 100% of them will. Also, this would've been an unintended change from our last version.