Map projectType correctly in getShouldExecuteCompressionTaskProvider#2134
Merged
Map projectType correctly in getShouldExecuteCompressionTaskProvider#2134
Conversation
fractalwrench
approved these changes
Apr 28, 2025
priettt
force-pushed
the
priettt/fixCustomSymbolsDirDependencies
branch
from
d3792d3 to
81eab56
Compare
priettt
force-pushed
the
priettt/improveExecutionTaskProvider
branch
from
66160c8 to
852ef0e
Compare
Base automatically changed from
priettt/fixCustomSymbolsDirDependencies
to
main
April 28, 2025 19:05
priettt
force-pushed
the
priettt/improveExecutionTaskProvider
branch
from
852ef0e to
71bd653
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
We were using
project.provider { projectType.orNull == ... }, which could cause early resolution of projectType, ignoring its dependencies. Using map wires it correctly.I think onlyIf might only be resolved in execution time, so we wouldn't be facing any issues here, but just in case, this is a more correct way of doing things.
Also, use map for failBuildOnUploadErrors instead of resolving it early.