Skip to content

Integration branch for Kotlin OTel API#2153

Merged
fractalwrench merged 53 commits intomainfrom
integration/kotlin-otel-api
Jun 26, 2025
Merged

Integration branch for Kotlin OTel API#2153
fractalwrench merged 53 commits intomainfrom
integration/kotlin-otel-api

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Integration branch for using the Kotlin OTel API.

@fractalwrench fractalwrench requested a review from a team as a code owner May 1, 2025 09:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 1, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@embrace-io/react-native ^5.2.0 UnknownUnknown
npm/@react-native/metro-config 0.79.0 🟢 5.1
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Security-Policy🟢 9security policy file detected
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1030 commit(s) and 15 issue activity found in the last 90 days -- score normalized to 10
Signed-Releases⚠️ -1no releases found
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
SAST⚠️ 0no SAST tool detected
Binary-Artifacts🟢 7binaries present in source code
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities⚠️ 012 existing vulnerabilities detected
npm/@react-native/typescript-config 0.79.0 🟢 5.1
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Security-Policy🟢 9security policy file detected
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1030 commit(s) and 15 issue activity found in the last 90 days -- score normalized to 10
Signed-Releases⚠️ -1no releases found
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
SAST⚠️ 0no SAST tool detected
Binary-Artifacts🟢 7binaries present in source code
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities⚠️ 012 existing vulnerabilities detected
npm/@types/react ^19.0.0 🟢 7
Details
CheckScoreReason
Code-Review🟢 9Found 27/30 approved changesets -- score normalized to 9
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy🟢 10security policy file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Fuzzing⚠️ 0project is not fuzzed
npm/react 19.0.0 UnknownUnknown
npm/react-native 0.79.0 🟢 5.1
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Security-Policy🟢 9security policy file detected
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1030 commit(s) and 15 issue activity found in the last 90 days -- score normalized to 10
Signed-Releases⚠️ -1no releases found
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
SAST⚠️ 0no SAST tool detected
Binary-Artifacts🟢 7binaries present in source code
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities⚠️ 012 existing vulnerabilities detected

Scanned Files

  • embrace-gradle-plugin-integration-tests/fixtures/react-native-android/package.json

Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@codecov
Copy link
Copy Markdown

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 83.37662% with 64 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (e38b3e4) to head (b79c2d2).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
...oid/embracesdk/internal/otel/payload/SpanMapper.kt 38.46% 4 Missing and 12 partials ⚠️
...d/embracesdk/internal/otel/KotlinApiConversions.kt 38.88% 7 Missing and 4 partials ⚠️
...k/internal/otel/wrapper/KotlinTraceStateWrapper.kt 23.07% 10 Missing ⚠️
...cesdk/internal/otel/impl/EmbOtelJavaSpanBuilder.kt 85.71% 2 Missing and 2 partials ⚠️
...sdk/internal/otel/logs/EmbraceLogRecordExporter.kt 57.14% 2 Missing and 1 partial ⚠️
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 66.66% 3 Missing ⚠️
...racesdk/internal/otel/spans/EmbraceSpanExporter.kt 57.14% 2 Missing and 1 partial ⚠️
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt 60.00% 0 Missing and 2 partials ⚠️
...embracesdk/internal/otel/sdk/StoreDataResultExt.kt 33.33% 1 Missing and 1 partial ⚠️
...esdk/internal/otel/spans/EmbraceSpanFactoryImpl.kt 95.65% 0 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
- Coverage   85.66%   85.41%   -0.25%     
==========================================
  Files         468      474       +6     
  Lines       10416    10500      +84     
  Branches     1536     1549      +13     
==========================================
+ Hits         8923     8969      +46     
- Misses        832      861      +29     
- Partials      661      670       +9     
Files with missing lines Coverage Δ
...embrace/android/embracesdk/internal/api/OTelApi.kt 100.00% <ø> (ø)
...io/embrace/android/embracesdk/spans/EmbraceSpan.kt 76.92% <ø> (ø)
...racesdk/internal/arch/destination/LogWriterImpl.kt 100.00% <100.00%> (ø)
...k/internal/injection/EssentialServiceModuleImpl.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/injection/InitModuleImpl.kt 100.00% <100.00%> (ø)
...mbracesdk/internal/injection/InitModuleSupplier.kt 75.00% <100.00%> (ø)
...esdk/internal/injection/OpenTelemetryModuleImpl.kt 96.38% <100.00%> (+0.18%) ⬆️
.../embracesdk/internal/capture/activity/UiLoadExt.kt 98.85% <100.00%> (ø)
...internal/capture/startup/AppStartupTraceEmitter.kt 86.05% <100.00%> (ø)
...race/android/embracesdk/internal/clock/ClockExt.kt 100.00% <100.00%> (ø)
... and 45 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

@github-actions github-actions bot added the stale label Jun 10, 2025
fractalwrench and others added 27 commits June 20, 2025 11:36
Use typealiases for opentelemetry-java
Use opentelemetry-kotlin implementation of Tracer
Retrieve parent from the context using the context key set by the Java SDK
Rename embrace otel java implementations
Remove unused clock in gradle plugin
@fractalwrench fractalwrench changed the title [DNM] Integration branch for Kotlin OTel API Integration branch for Kotlin OTel API Jun 26, 2025
@fractalwrench fractalwrench merged commit bed0d61 into main Jun 26, 2025
11 checks passed
@fractalwrench fractalwrench deleted the integration/kotlin-otel-api branch June 26, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants