Preparatory work for kotlin api#2198
Merged
fractalwrench merged 1 commit intointegration/kotlin-otel-apifrom Jun 16, 2025
Merged
Preparatory work for kotlin api#2198fractalwrench merged 1 commit intointegration/kotlin-otel-apifrom
fractalwrench merged 1 commit intointegration/kotlin-otel-apifrom
Conversation
3c9941e to
a23efe1
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## integration/kotlin-otel-api #2198 +/- ##
===============================================================
- Coverage 85.47% 85.20% -0.28%
===============================================================
Files 467 470 +3
Lines 10416 10448 +32
Branches 1532 1534 +2
===============================================================
- Hits 8903 8902 -1
- Misses 853 885 +32
- Partials 660 661 +1
🚀 New features to boost your workflow:
|
a23efe1 to
1ede78f
Compare
bidetofevil
approved these changes
May 27, 2025
Contributor
bidetofevil
left a comment
There was a problem hiding this comment.
LGTM. I did similar fakes in my test usage in opentelemetry-android so maybe we should have a repo that contains those.
01f9ed5
into
integration/kotlin-otel-api
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Creates some wrappers + fakes that are required to move over to using the Kotlin API.
Testing
This will be covered by existing tests once the internal implementation uses these objects.