Skip to content

Preparatory work for kotlin api#2198

Merged
fractalwrench merged 1 commit intointegration/kotlin-otel-apifrom
kotlin-api-additions
Jun 16, 2025
Merged

Preparatory work for kotlin api#2198
fractalwrench merged 1 commit intointegration/kotlin-otel-apifrom
kotlin-api-additions

Conversation

@fractalwrench
Copy link
Member

Goal

Creates some wrappers + fakes that are required to move over to using the Kotlin API.

Testing

This will be covered by existing tests once the internal implementation uses these objects.

@fractalwrench fractalwrench requested a review from a team as a code owner May 8, 2025 14:52
@fractalwrench fractalwrench force-pushed the kotlin-api-additions branch from 3c9941e to a23efe1 Compare May 8, 2025 14:59
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (eb9c77f) to head (1ede78f).
Report is 2 commits behind head on integration/kotlin-otel-api.

Files with missing lines Patch % Lines
...k/internal/otel/wrapper/KotlinTraceStateWrapper.kt 0.00% 13 Missing ⚠️
.../internal/otel/wrapper/KotlinSpanContextWrapper.kt 0.00% 7 Missing ⚠️
...d/embracesdk/internal/otel/KotlinApiConversions.kt 0.00% 6 Missing ⚠️
...k/internal/otel/wrapper/KotlinTraceFlagsWrapper.kt 0.00% 5 Missing ⚠️
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           integration/kotlin-otel-api    #2198      +/-   ##
===============================================================
- Coverage                        85.47%   85.20%   -0.28%     
===============================================================
  Files                              467      470       +3     
  Lines                            10416    10448      +32     
  Branches                          1532     1534       +2     
===============================================================
- Hits                              8903     8902       -1     
- Misses                             853      885      +32     
- Partials                           660      661       +1     
Files with missing lines Coverage Δ
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 73.17% <0.00%> (-1.83%) ⬇️
...k/internal/otel/wrapper/KotlinTraceFlagsWrapper.kt 0.00% <0.00%> (ø)
...d/embracesdk/internal/otel/KotlinApiConversions.kt 42.10% <0.00%> (-19.44%) ⬇️
.../internal/otel/wrapper/KotlinSpanContextWrapper.kt 0.00% <0.00%> (ø)
...k/internal/otel/wrapper/KotlinTraceStateWrapper.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did similar fakes in my test usage in opentelemetry-android so maybe we should have a repo that contains those.

@fractalwrench fractalwrench merged commit 01f9ed5 into integration/kotlin-otel-api Jun 16, 2025
4 of 5 checks passed
@fractalwrench fractalwrench deleted the kotlin-api-additions branch June 16, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants