Skip to content

Add explicit test for max temp session properties#2213

Merged
bidetofevil merged 1 commit intomainfrom
hho/session-props-utests
Jun 3, 2025
Merged

Add explicit test for max temp session properties#2213
bidetofevil merged 1 commit intomainfrom
hho/session-props-utests

Conversation

@bidetofevil
Copy link
Contributor

@bidetofevil bidetofevil commented May 21, 2025

Goal

Added a couple of additional conditions that we don't explicitly test for session properties

@bidetofevil bidetofevil requested a review from a team as a code owner May 21, 2025 22:05
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor Author

bidetofevil commented May 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil requested a review from priettt May 21, 2025 22:06
Copy link
Contributor Author

bidetofevil commented Jun 3, 2025

Merge activity

  • Jun 3, 2:45 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 3, 2:46 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 3, 2:56 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 3, 3:12 PM UTC: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil force-pushed the hho/session-props-utests branch from ec4f2b4 to 6693034 Compare June 3, 2025 14:45
@bidetofevil bidetofevil force-pushed the hho/session-props-utests branch from 6693034 to 9f96d52 Compare June 3, 2025 14:55
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.61%. Comparing base (efb0952) to head (9f96d52).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2213   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         466      466           
  Lines       10380    10380           
  Branches     1522     1522           
=======================================
  Hits         8887     8887           
  Misses        836      836           
  Partials      657      657           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bidetofevil bidetofevil merged commit 39c295e into main Jun 3, 2025
12 checks passed
@bidetofevil bidetofevil deleted the hho/session-props-utests branch June 3, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants