Removed afterEvaluate from AsmTaskRegistration#2220
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
priettt
changed the base branch from
main
to
priettt/reactNativeGradlePluginImprovements
priettt
changed the title
priettt
force-pushed
the
priettt/removeAfterEvaluateFromAsm
branch
from
7d65c05 to
ba4afa6
Compare
priettt
force-pushed
the
priettt/reactNativeGradlePluginImprovements
branch
from
ddb256c to
e9cdc3c
Compare
Base automatically changed from
priettt/reactNativeGradlePluginImprovements
to
main
June 2, 2025 17:47
priettt
force-pushed
the
priettt/removeAfterEvaluateFromAsm
branch
4 times, most recently
from
c4e475e to
900b9c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
=======================================
Coverage 85.62% 85.62%
=======================================
Files 467 467
Lines 10398 10398
Branches 1531 1531
=======================================
Hits 8903 8903
Misses 836 836
Partials 659 659 🚀 New features to boost your workflow:
|
priettt
force-pushed
the
priettt/removeAfterEvaluateFromAsm
branch
4 times, most recently
from
0b9db71 to
b32783b
Compare
…kup utility function
priettt
force-pushed
the
priettt/removeAfterEvaluateFromAsm
branch
from
b32783b to
aef19ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Mapped task outputs correctly to asm task parameters without using afterEvaluate. Also added a lazyTaskLookup utility function.