Remove 10 parameter limit in OpenTelemetry export#2221
Remove 10 parameter limit in OpenTelemetry export#2221mmarczell-graphisoft wants to merge 3 commits intoembrace-io:mainfrom
Conversation
…kend and not externally added OTel Exporters
|
This looks good! I'm going to check a couple things and then merge it after you make the changes to get it to pass CI (it seems to be a detekt failure so running There are a couple of additional changes we'll want to make on top of this but it gives us a good basis from which to work. Thanks for contributing! |
|
|
||
| fun Attributes.toEmbracePayload(): List<Attribute> = | ||
| this.asMap().entries.map { Attribute(it.key.key, it.value.toString()) } | ||
| this.asMap().entries |
There was a problem hiding this comment.
@priettt pointed out that you should reverse the order of take and map - feel free to fix it along with the detekt error or we can deal with it when we make the additional changes (we may change where the truncation happens so don't spend too much time on it).
|
Hey @mmarczell-graphisoft - looks like there are still some test failures because we were expecting the same data in the export as in the internal representation. I did some refactoring of our internals and reimplemented what you did in #2225, which should take care of your use case. Can you test it when it merges? |
|
@bidetofevil I can test it when it merges, no problem. |
|
@bidetofevil I tested main and it worked, thanks |
|
Excellent! Do you still need any part of the PR or can it be closed? If |
2 participants
Goal
The Android SDK caps the number of custom properties in a log event to 10, even when external OpenTelemetry export is used. The iOS SDK doesn't. This PR lets the OpenTelemetry export contain all the properties without limitation, while the logs sent to the Embrace backend are capped to 10 properties as before.
Testing
Release Notes
The number of log properties in the OpenTelemetry export is no longer capped to 10.