Use new GH action to upload SDK version info#2222
Merged
Conversation
Contributor
Dependency ReviewThe following issues were found:
License Issues.github/workflows/release-workflow.yml
OpenSSF Scorecard
Scanned Files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vitaliyf
approved these changes
May 30, 2025
vitaliyf
reviewed
May 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
=======================================
Coverage 85.62% 85.62%
=======================================
Files 465 465
Lines 10379 10379
Branches 1522 1522
=======================================
Hits 8887 8887
Misses 835 835
Partials 657 657 🚀 New features to boost your workflow:
|
bidetofevil
reviewed
Jun 2, 2025
| timeout-minutes: 60 | ||
| steps: | ||
| - name: Validate access to version data service | ||
| uses: embrace-io/public-actions/upload-sdk-version@f4229398f257b24dbbe8b873f78e719f9af6cbbb |
Contributor
There was a problem hiding this comment.
What is this pinned ID for?
Contributor
Author
There was a problem hiding this comment.
that's the sha for the version of the upload-sdk-version action. GH warns you if you do anything less strict than that for 3rd party actions. this may seem like a bit of overkill, but is probably a response to attacks that have occurred in the past where people changed the behavior of public actions. even though we control the action, GH sees it as a 3rd party one
bidetofevil
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Testing
Release Notes
WHAT:
WHY: