Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class EmbSpan(
private val clock: Clock,
) : Span {

override fun <T : Any> setAttribute(key: AttributeKey<T>, value: T): Span {
override fun <T : Any> setAttribute(key: AttributeKey<T>, value: T?): Span {
embraceSpan.addAttribute(key = key.key, value = value.toString())
return this
}
Expand Down
3 changes: 3 additions & 0 deletions embrace-android-sdk/embrace-proguard.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
## OpenTelemetry Java SDK
-keep class io.opentelemetry.api.trace.StatusCode { *; }
-dontwarn com.google.auto.value.extension.memoized.Memoized
-dontwarn io.opentelemetry.api.incubator.common.ExtendedAttributeKey
-dontwarn io.opentelemetry.api.incubator.common.ExtendedAttributes
-dontwarn io.opentelemetry.api.incubator.common.ExtendedAttributesBuilder
-dontwarn io.opentelemetry.api.incubator.logs.ExtendedLogRecordBuilder
-dontwarn io.opentelemetry.api.incubator.logs.ExtendedLogger
-dontwarn io.opentelemetry.api.incubator.trace.ExtendedSpanBuilder
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.embrace.android.embracesdk.fakes

import android.os.Build
import androidx.annotation.RequiresApi
import io.opentelemetry.api.common.AttributeKey
import io.opentelemetry.api.logs.LogRecordBuilder
import io.opentelemetry.api.logs.Severity
Expand All @@ -23,6 +25,7 @@ class FakeLogRecordBuilder : LogRecordBuilder {
return this
}

@RequiresApi(Build.VERSION_CODES.O)
override fun setTimestamp(instant: Instant): LogRecordBuilder {
timestampEpochNanos = instant.toEpochMilli() * 1_000_000
return this
Expand All @@ -33,6 +36,7 @@ class FakeLogRecordBuilder : LogRecordBuilder {
return this
}

@RequiresApi(Build.VERSION_CODES.O)
override fun setObservedTimestamp(instant: Instant): LogRecordBuilder {
observedTimestampEpochNanos = instant.toEpochMilli() * 1_000_000
return this
Expand All @@ -58,7 +62,7 @@ class FakeLogRecordBuilder : LogRecordBuilder {
return this
}

override fun <T : Any> setAttribute(key: AttributeKey<T>, value: T): LogRecordBuilder {
override fun <T : Any> setAttribute(key: AttributeKey<T>, value: T?): LogRecordBuilder {
attributes[key.key.toString()] = value.toString()
return this
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,11 @@ class FakeSpan(
private var status: StatusCode = StatusCode.UNSET
private var statusDescription: String = ""

override fun <T : Any> setAttribute(key: AttributeKey<T>, value: T): Span {
fakeSpanBuilder.setAttribute(key, value)
override fun <T : Any> setAttribute(key: AttributeKey<T>, value: T?): Span {
if (value != null) {
fakeSpanBuilder.setAttribute(key, value)
}

return this
}

Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dokka = "1.9.20"
kotlinGradlePlugin = "2.1.21"
koverGradlePlugin = "0.9.1"
lint = "31.10.1"
openTelemetryCore = "1.49.0"
openTelemetryCore = "1.51.0"
openTelementrySemConv = "1.29.0-alpha"
moshi = "1.15.2"
lifecycle = "2.7.0" # version pinned to 2.7.0 because of AGP bug
Expand Down
Loading