Skip to content

Increase limit for log properties to 100#2241

Closed
bidetofevil wants to merge 1 commit intomainfrom
hho/up-log-props-limit
Closed

Increase limit for log properties to 100#2241
bidetofevil wants to merge 1 commit intomainfrom
hho/up-log-props-limit

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Jun 13, 2025

Goal

Change the hardcoded limit for the number of properties set on Embrace logs to 50 and up the limit of total attributes on OTel logs to support the case of setting over 100 session properties

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Jun 13, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil requested a review from priettt June 13, 2025 18:33
@bidetofevil bidetofevil marked this pull request as ready for review June 13, 2025 18:33
@bidetofevil bidetofevil requested a review from a team as a code owner June 13, 2025 18:33
@bidetofevil bidetofevil changed the base branch from hho/update-otel-1.51 to graphite-base/2241 June 13, 2025 18:47
@bidetofevil bidetofevil force-pushed the hho/up-log-props-limit branch from 35224e3 to 50a31ad Compare June 13, 2025 18:47
@graphite-app graphite-app bot changed the base branch from graphite-base/2241 to main June 13, 2025 18:47
@bidetofevil bidetofevil force-pushed the hho/up-log-props-limit branch from 50a31ad to 9ca5114 Compare June 13, 2025 18:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (1671dc9) to head (de11c7d).
Report is 179 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
+ Coverage   85.58%   85.60%   +0.01%     
==========================================
  Files         467      467              
  Lines       10400    10406       +6     
  Branches     1532     1532              
==========================================
+ Hits         8901     8908       +7     
  Misses        838      838              
+ Partials      661      660       -1     
Files with missing lines Coverage Δ
...android/embracesdk/internal/utils/PropertyUtils.kt 83.33% <ø> (ø)
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor Author

Won't merge this until we figure out how to get this done on all platforms

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 4, 2025

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

@github-actions github-actions bot added the stale label Jul 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This PR was closed due to inactivity.

@github-actions github-actions bot closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants