Skip to content

Setup exporters correctly via Kotlin API#2299

Merged
fractalwrench merged 1 commit intomainfrom
further-kotlin-dsl-usage
Jul 4, 2025
Merged

Setup exporters correctly via Kotlin API#2299
fractalwrench merged 1 commit intomainfrom
further-kotlin-dsl-usage

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Builds on embrace-io/opentelemetry-kotlin#140 by using exporters to create an OpenTelemetry object via the Kotlin API.

@fractalwrench fractalwrench requested a review from a team as a code owner July 1, 2025 13:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 1, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@fractalwrench fractalwrench force-pushed the further-kotlin-dsl-usage branch 3 times, most recently from 919ec57 to 47382c1 Compare July 4, 2025 13:40
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the further-kotlin-dsl-usage branch from 47382c1 to 8ca9204 Compare July 4, 2025 15:35
@fractalwrench fractalwrench force-pushed the further-kotlin-dsl-usage branch from 8ca9204 to 17aef18 Compare July 4, 2025 15:49
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (b22e5c0) to head (17aef18).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 0.00% 2 Missing ⚠️
...acesdk/internal/otel/spans/DefaultSpanProcessor.kt 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   85.19%   85.17%   -0.02%     
==========================================
  Files         476      476              
  Lines       10547    10550       +3     
  Branches     1550     1550              
==========================================
+ Hits         8985     8986       +1     
- Misses        891      894       +3     
+ Partials      671      670       -1     
Files with missing lines Coverage Δ
.../internal/otel/wrapper/KotlinSpanContextWrapper.kt 100.00% <100.00%> (ø)
...k/internal/otel/wrapper/KotlinTraceStateWrapper.kt 23.07% <100.00%> (ø)
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 73.21% <0.00%> (-1.34%) ⬇️
...acesdk/internal/otel/spans/DefaultSpanProcessor.kt 63.63% <0.00%> (-14.15%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fractalwrench fractalwrench merged commit 2058d65 into main Jul 4, 2025
10 of 11 checks passed
@fractalwrench fractalwrench deleted the further-kotlin-dsl-usage branch July 4, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants