Migrate to vanniktech maven publish

[priettt]

Goal

Use https://github.com/vanniktech/gradle-maven-publish-plugin for publishing to Maven Central. We were using a temporal workaround, and this plugin seems better maintained and widely used in many other projects.

Changes:

• Add and use vanniktech.maven.publish.
• Add ORG_GRADLE_PROJECT_ prefix to environment variables in workflows, as the plugin looks for those variables automatically.
• Add publish-snapshot.yml. It will publish a snapshot daily, or on trigger.
• Remove release-workflow.yml, as we now only upload artifacts to maven central, and then we publish manually.
• Updated and renamed upload-artifacts-to-sonatype.yml, we now use it to publish artifacts.
• Remove uses of nexus-publish, maven-publish, and signing plugins, as they're replaced by vanniktech.
• Remove Embrace QA and Beta repos, they aren't used anymore.
• Remove java { withJavadoc... } blocks, as vanniktech adds them automatically.
• Remove gradle plugin marker creation, as vanniktech does that automatically.
• Remove signing blocks, as vanniktech reads the ORG_GRADLE_PROJECT_ env vars in our workflows, and signs releases automatically.
• Will update our internal release docs to reflect how we can test manually.

I released two test versions, one without changes, one with the vanniktech plugin. They both look the same, same artifacts are uploaded, and they both work when tested manually.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details
actions/embrace-io/public-actions/upload-sdk-version	88167cd1a3fce3418e26c8c842026e6dfab99e41	Unknown	Unknown
actions/actions/setup-java	4.*.*	🟢 5.6	Details Check Score Reason Code-Review 🟢 10 all changesets reviewed Maintained 🟢 3 4 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 3 Binary-Artifacts 🟢 10 no binaries found in the repo Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Packaging ⚠️ -1 packaging workflow not detected License 🟢 10 license file detected Token-Permissions ⚠️ 0 detected GitHub workflow tokens with excessive permissions Fuzzing ⚠️ 0 project is not fuzzed Signed-Releases ⚠️ -1 no releases found Pinned-Dependencies ⚠️ 0 dependency not pinned by hash detected -- score normalized to 0 Security-Policy 🟢 9 security policy file detected Branch-Protection ⚠️ 0 branch protection not enabled on development/release branches SAST 🟢 9 SAST tool is not run on all commits -- score normalized to 9 Vulnerabilities 🟢 8 2 existing vulnerabilities detected
actions/gradle/actions/setup-gradle	ac638b010cf58a27ee6c972d7336334ccaf61c96	🟢 7.7	Details Check Score Reason Code-Review ⚠️ 0 Found 1/14 approved changesets -- score normalized to 0 Maintained 🟢 10 30 commit(s) and 12 issue activity found in the last 90 days -- score normalized to 10 Dependency-Update-Tool 🟢 10 update tool detected Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected License 🟢 10 license file detected Packaging ⚠️ -1 packaging workflow not detected Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Pinned-Dependencies 🟢 10 all dependencies are pinned SAST 🟢 9 SAST tool detected but not run on all commits Signed-Releases ⚠️ -1 no releases found Fuzzing ⚠️ 0 project is not fuzzed Branch-Protection 🟢 3 branch protection is not maximal on development and all release branches Binary-Artifacts 🟢 10 no binaries found in the repo Security-Policy 🟢 10 security policy file detected Vulnerabilities 🟢 9 1 existing vulnerabilities detected CI-Tests 🟢 10 10 out of 10 merged PRs checked by a CI test -- score normalized to 10 Contributors 🟢 10 project has 7 contributing companies or organizations
actions/actions/checkout	4.*.*	🟢 5.2	Details Check Score Reason Binary-Artifacts 🟢 10 no binaries found in the repo Maintained ⚠️ 0 1 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0 Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Code-Review 🟢 10 all changesets reviewed Token-Permissions ⚠️ 0 detected GitHub workflow tokens with excessive permissions CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Fuzzing ⚠️ 0 project is not fuzzed License 🟢 10 license file detected Packaging ⚠️ -1 packaging workflow not detected Signed-Releases ⚠️ -1 no releases found Pinned-Dependencies 🟢 3 dependency not pinned by hash detected -- score normalized to 3 Security-Policy 🟢 9 security policy file detected Branch-Protection ⚠️ -1 internal error: error during GetBranch(releases/v2): error during branchesHandler.query: internal error: githubv4.Query: Resource not accessible by integration SAST 🟢 9 SAST tool detected but not run on all commits Vulnerabilities ⚠️ 0 10 existing vulnerabilities detected
actions/actions/setup-java	4.*.*	🟢 5.6	Details Check Score Reason Code-Review 🟢 10 all changesets reviewed Maintained 🟢 3 4 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 3 Binary-Artifacts 🟢 10 no binaries found in the repo Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Packaging ⚠️ -1 packaging workflow not detected License 🟢 10 license file detected Token-Permissions ⚠️ 0 detected GitHub workflow tokens with excessive permissions Fuzzing ⚠️ 0 project is not fuzzed Signed-Releases ⚠️ -1 no releases found Pinned-Dependencies ⚠️ 0 dependency not pinned by hash detected -- score normalized to 0 Security-Policy 🟢 9 security policy file detected Branch-Protection ⚠️ 0 branch protection not enabled on development/release branches SAST 🟢 9 SAST tool is not run on all commits -- score normalized to 9 Vulnerabilities 🟢 8 2 existing vulnerabilities detected
actions/gradle/actions/setup-gradle	ac638b010cf58a27ee6c972d7336334ccaf61c96	🟢 7.7	Details Check Score Reason Code-Review ⚠️ 0 Found 1/14 approved changesets -- score normalized to 0 Maintained 🟢 10 30 commit(s) and 12 issue activity found in the last 90 days -- score normalized to 10 Dependency-Update-Tool 🟢 10 update tool detected Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected License 🟢 10 license file detected Packaging ⚠️ -1 packaging workflow not detected Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Pinned-Dependencies 🟢 10 all dependencies are pinned SAST 🟢 9 SAST tool detected but not run on all commits Signed-Releases ⚠️ -1 no releases found Fuzzing ⚠️ 0 project is not fuzzed Branch-Protection 🟢 3 branch protection is not maximal on development and all release branches Binary-Artifacts 🟢 10 no binaries found in the repo Security-Policy 🟢 10 security policy file detected Vulnerabilities 🟢 9 1 existing vulnerabilities detected CI-Tests 🟢 10 10 out of 10 merged PRs checked by a CI test -- score normalized to 10 Contributors 🟢 10 project has 7 contributing companies or organizations

Scanned Files

• .github/workflows/publish-api-docs.yml
• .github/workflows/publish-snapshot.yml
• .github/workflows/release-workflow.yml
• .github/workflows/upload-artifacts-to-maven-central.yml
• .github/workflows/upload-artifacts-to-sonatype.yml

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (9f8c1de) to head (ab1aac5).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
- Coverage   85.20%   85.19%   -0.01%     
==========================================
  Files         476      476              
  Lines       10547    10547              
  Branches     1550     1550              
==========================================
- Hits         8987     8986       -1     
+ Misses        891      890       -1     
- Partials      669      671       +2     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bidetofevil]

It is ok to pin things to this SHA?

[priettt]

That's how it's done everywhere, at least for this particular action. I'm not a fan, but I think it's the only way to make an action immutable. @fnewberg might have additional reasons

[bidetofevil]

Feels like "current version" should be defined as a variable and be referenced everywhere so we don't have to make N changes when the version revs. Not a blocker - just something to consider.

[bidetofevil]

This is in the middle of a work day. Why not 5 UTC or something to ensure it's done when Jamie gets online?

[bidetofevil]

Is there a way we can apply the same Java config to all of our builds, production, snapshot, and otherwise?

[priettt]

we could use a shared workflow, though I'm not sure if it'd work

[bidetofevil]

LGTM. Some comments about logic consolidation and snapshot timing but not blocking