Skip to content

Use kotlin OTel clock#2315

Merged
fractalwrench merged 10 commits intomainfrom
use-kt-clock
Jul 8, 2025
Merged

Use kotlin OTel clock#2315
fractalwrench merged 10 commits intomainfrom
use-kt-clock

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Refactors code to use the Kotlin API for Clock.

@fractalwrench fractalwrench requested a review from a team as a code owner July 7, 2025 09:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 18 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (85c9bc1) to head (bd553d9).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...sdk/internal/otel/logs/DefaultLogRecordExporter.kt 68.75% 3 Missing and 2 partials ⚠️
...racesdk/internal/otel/spans/DefaultSpanExporter.kt 72.22% 3 Missing and 2 partials ⚠️
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 85.71% 1 Missing and 2 partials ⚠️
...acesdk/internal/otel/spans/EmbraceSpanProcessor.kt 78.57% 3 Missing ⚠️
...roid/embracesdk/internal/otel/payload/LogMapper.kt 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2315      +/-   ##
==========================================
+ Coverage   85.23%   85.38%   +0.14%     
==========================================
  Files         478      477       -1     
  Lines       10568    10539      -29     
  Branches     1552     1557       +5     
==========================================
- Hits         9008     8999       -9     
+ Misses        894      867      -27     
- Partials      666      673       +7     
Files with missing lines Coverage Δ
...d/embracesdk/internal/otel/config/OtelSdkConfig.kt 100.00% <100.00%> (+19.04%) ⬆️
...d/embracesdk/internal/otel/impl/EmbOtelJavaSpan.kt 96.66% <100.00%> (ø)
...cesdk/internal/otel/impl/EmbOtelJavaSpanBuilder.kt 85.71% <100.00%> (ø)
...embracesdk/internal/otel/impl/EmbOtelJavaTracer.kt 100.00% <100.00%> (ø)
...dk/internal/otel/impl/EmbOtelJavaTracerProvider.kt 95.65% <100.00%> (ø)
...oid/embracesdk/internal/otel/payload/SpanMapper.kt 58.53% <ø> (-0.29%) ⬇️
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 100.00% <100.00%> (+26.78%) ⬆️
.../android/embracesdk/internal/otel/sdk/TracerExt.kt 100.00% <ø> (+4.54%) ⬆️
...esdk/internal/otel/spans/EmbraceSpanFactoryImpl.kt 92.27% <100.00%> (ø)
...mbracesdk/internal/api/delegate/OTelApiDelegate.kt 100.00% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 5d90544 into main Jul 8, 2025
11 checks passed
@fractalwrench fractalwrench deleted the use-kt-clock branch July 8, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants