Skip to content

Remove unused OTel java function#2316

Merged
fractalwrench merged 1 commit intouse-kt-clockfrom
remove-unused-java-function
Jul 8, 2025
Merged

Remove unused OTel java function#2316
fractalwrench merged 1 commit intouse-kt-clockfrom
remove-unused-java-function

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Removes an unused function call that relies on OTel Java.

@fractalwrench fractalwrench requested a review from a team as a code owner July 7, 2025 10:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (7b1141e) to head (52d4cb9).
Report is 8 commits behind head on use-kt-clock.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           use-kt-clock    #2316   +/-   ##
=============================================
  Coverage         85.17%   85.18%           
=============================================
  Files               477      477           
  Lines             10552    10541   -11     
  Branches           1550     1550           
=============================================
- Hits               8988     8979    -9     
+ Misses              894      893    -1     
+ Partials            670      669    -1     
Files with missing lines Coverage Δ
.../android/embracesdk/internal/otel/sdk/TracerExt.kt 100.00% <ø> (+4.54%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Wonder why we needed an overload that passes the clock in....

@fractalwrench fractalwrench force-pushed the remove-unused-java-function branch from c833b61 to 52d4cb9 Compare July 7, 2025 16:01
@fractalwrench fractalwrench merged commit 3810972 into use-kt-clock Jul 8, 2025
5 checks passed
@fractalwrench fractalwrench deleted the remove-unused-java-function branch July 8, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants