Skip to content

Use kotlin DSL for initialising opentelemetry#2317

Merged
fractalwrench merged 1 commit intouse-kt-clockfrom
use-kotlin-dsl
Jul 8, 2025
Merged

Use kotlin DSL for initialising opentelemetry#2317
fractalwrench merged 1 commit intouse-kt-clockfrom
use-kotlin-dsl

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Uses the new Kotlin DSL for initializing the OpenTelemetry object.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner July 7, 2025 12:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (52d4cb9) to head (1fd5ac5).
Report is 15 commits behind head on use-kt-clock.

Files with missing lines Patch % Lines
...acesdk/internal/otel/spans/EmbraceSpanProcessor.kt 78.57% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           use-kt-clock    #2317      +/-   ##
================================================
+ Coverage         85.18%   85.37%   +0.18%     
================================================
  Files               477      476       -1     
  Lines             10541    10500      -41     
  Branches           1550     1550              
================================================
- Hits               8979     8964      -15     
+ Misses              893      868      -25     
+ Partials            669      668       -1     
Files with missing lines Coverage Δ
...d/embracesdk/internal/otel/config/OtelSdkConfig.kt 100.00% <100.00%> (+19.04%) ⬆️
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 100.00% <100.00%> (+26.78%) ⬆️
...esdk/internal/otel/spans/EmbraceSpanFactoryImpl.kt 91.84% <100.00%> (ø)
...mbracesdk/internal/api/delegate/OTelApiDelegate.kt 100.00% <100.00%> (ø)
...acesdk/internal/otel/spans/EmbraceSpanProcessor.kt 78.57% <78.57%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fractalwrench fractalwrench force-pushed the remove-unused-java-function branch from c833b61 to 52d4cb9 Compare July 7, 2025 16:01
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

Base automatically changed from remove-unused-java-function to use-kt-clock July 8, 2025 09:20
@fractalwrench fractalwrench merged commit e33837d into use-kt-clock Jul 8, 2025
5 checks passed
@fractalwrench fractalwrench deleted the use-kotlin-dsl branch July 8, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants