Skip to content

Remove further opentelemetry-java references#2318

Merged
fractalwrench merged 1 commit intouse-kt-clockfrom
refactor-utils
Jul 8, 2025
Merged

Remove further opentelemetry-java references#2318
fractalwrench merged 1 commit intouse-kt-clockfrom
refactor-utils

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Removes further references to opentelemetry-java in the project

@fractalwrench fractalwrench requested a review from a team as a code owner July 7, 2025 12:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (1fd5ac5) to head (b2fd5e5).
Report is 14 commits behind head on use-kt-clock.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           use-kt-clock    #2318      +/-   ##
================================================
+ Coverage         85.37%   85.39%   +0.01%     
================================================
  Files               476      476              
  Lines             10500    10486      -14     
  Branches           1550     1546       -4     
================================================
- Hits               8964     8954      -10     
+ Misses              868      864       -4     
  Partials            668      668              
Files with missing lines Coverage Δ
...oid/embracesdk/internal/otel/payload/SpanMapper.kt 58.53% <ø> (-0.29%) ⬇️
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 74.28% <ø> (+7.61%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess the toFailedSpan() used to be used by the resurrection code but isn't anymore?

Copy link
Copy Markdown
Contributor

Ah, I guess this exists in SpanExt.kt still

Base automatically changed from use-kotlin-dsl to use-kt-clock July 8, 2025 09:21
@fractalwrench fractalwrench merged commit ae17c65 into use-kt-clock Jul 8, 2025
5 checks passed
@fractalwrench fractalwrench deleted the refactor-utils branch July 8, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants