Skip to content

Use kotlin API for exporters#2319

Merged
fractalwrench merged 1 commit intouse-kt-clockfrom
refactor-exporters
Jul 8, 2025
Merged

Use kotlin API for exporters#2319
fractalwrench merged 1 commit intouse-kt-clockfrom
refactor-exporters

Conversation

@fractalwrench
Copy link
Copy Markdown
Member

Goal

Refactors the span/log exporter implementation to use the Kotlin API where possible.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner July 7, 2025 14:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.34%. Comparing base (b2fd5e5) to head (3c2260e).
Report is 13 commits behind head on use-kt-clock.

Files with missing lines Patch % Lines
...sdk/internal/otel/logs/DefaultLogRecordExporter.kt 68.75% 3 Missing and 2 partials ⚠️
...racesdk/internal/otel/spans/DefaultSpanExporter.kt 72.22% 3 Missing and 2 partials ⚠️
...roid/embracesdk/internal/otel/payload/LogMapper.kt 77.77% 0 Missing and 2 partials ⚠️
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 90.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           use-kt-clock    #2319      +/-   ##
================================================
- Coverage         85.39%   85.34%   -0.05%     
================================================
  Files               476      476              
  Lines             10486    10523      +37     
  Branches           1546     1555       +9     
================================================
+ Hits               8954     8981      +27     
- Misses              864      867       +3     
- Partials            668      675       +7     
Files with missing lines Coverage Δ
...d/embracesdk/internal/otel/config/OtelSdkConfig.kt 100.00% <100.00%> (ø)
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 100.00% <100.00%> (ø)
...roid/embracesdk/internal/otel/payload/LogMapper.kt 78.94% <77.77%> (-21.06%) ⬇️
...ce/android/embracesdk/internal/otel/sdk/OtelExt.kt 78.18% <90.00%> (+3.89%) ⬆️
...sdk/internal/otel/logs/DefaultLogRecordExporter.kt 68.75% <68.75%> (ø)
...racesdk/internal/otel/spans/DefaultSpanExporter.kt 72.22% <72.22%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from refactor-utils to use-kt-clock July 8, 2025 09:21
@fractalwrench fractalwrench merged commit 21e0c4c into use-kt-clock Jul 8, 2025
5 checks passed
@fractalwrench fractalwrench deleted the refactor-exporters branch July 8, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants