Skip to content

Require AGP 8.3+ and special flag if minSdk < 26 #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bidetofevil merged 1 commit into from
Jul 15, 2025
Merged

Require AGP 8.3+ and special flag if minSdk < 26 #2359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...adle-plugin/src/main/java/io/embrace/android/gradle/plugin/EmbraceGradlePluginDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,14 @@ class EmbraceGradlePluginDelegate {
private fun verifySemConvWorkaround(project: Project, agpWrapper: AgpWrapper) {
val minSdk = agpWrapper.minSdk ?: return

if (minSdk < 24) {
if (minSdk < 26) {
if (agpWrapper.version <= AgpVersion.AGP_8_3_0 ||
project.getProperty("android.useFullClasspathForDexingTransform").orNull != "true"
) {
error(
"To use the Embrace SDK when your minSdk is lower than 24 " +
"To use the Embrace SDK when your minSdk is lower than 26 " +
"you must use AGP 8.3.0+ and add android.useFullClasspathForDexingTransform=true to " +
"gradle.properties.\nAlternatively you can set your minSdk to 24 or higher.\n" +
"gradle.properties.\nAlternatively you can set your minSdk to 26 or higher.\n" +
"This avoids a desugaring bug in old AGP versions that will lead to runtime crashes on old devices.\n" +
"For the full context for this workaround, please see the following issue:" +
" https://issuetracker.google.com/issues/230454566#comment18"
Expand Down
Loading