Skip to content

Remove appId from sample app#2387

Merged
bidetofevil merged 1 commit intomainfrom
hho/remove-appid
Jul 21, 2025
Merged

Remove appId from sample app#2387
bidetofevil merged 1 commit intomainfrom
hho/remove-appid

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Jul 18, 2025

Goal

Remove test appId from the sample app. It should be specified locally in the environment config.

@bidetofevil bidetofevil requested a review from a team as a code owner July 18, 2025 16:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil requested a review from priettt July 18, 2025 17:00
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (53556a0) to head (ef19e92).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files         482      482           
  Lines       10635    10635           
  Branches     1569     1569           
=======================================
  Hits         8981     8981           
  Misses        987      987           
  Partials      667      667           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Jul 21, 2025

Merge activity

  • Jul 21, 6:59 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 21, 7:00 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 21, 7:09 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 21, 7:18 PM UTC: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 0207d0c into main Jul 21, 2025
10 checks passed
@bidetofevil bidetofevil deleted the hho/remove-appid branch July 21, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants