Skip to content

Increase limit for log properties to 100#2392

Merged
bidetofevil merged 3 commits intomainfrom
hho/up-log-props-limit
Jul 22, 2025
Merged

Increase limit for log properties to 100#2392
bidetofevil merged 3 commits intomainfrom
hho/up-log-props-limit

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Jul 21, 2025

Goal

Update limits for attribute key length, value length, and counts to 128, 1024, and 100, respectively. Add a cap of 200 for remote configured session prop limits as well.

PropertyUtil was also refactored so it contains a truncation method, but the sanitization method was inlined into the EmbraceLogService class because that's the only place that used it. Tests were ported too - at least the relevant ones.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 21, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil force-pushed the hho/up-log-props-limit branch from 763965a to 9ce5f40 Compare July 22, 2025 05:48
@bidetofevil bidetofevil marked this pull request as ready for review July 22, 2025 05:55
@bidetofevil bidetofevil requested a review from a team as a code owner July 22, 2025 05:55
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (525781d) to head (0be2f5f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...roid/embracesdk/internal/logs/EmbraceLogService.kt 82.35% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2392   +/-   ##
=======================================
  Coverage   84.38%   84.39%           
=======================================
  Files         482      482           
  Lines       10642    10648    +6     
  Branches     1571     1571           
=======================================
+ Hits         8980     8986    +6     
- Misses        994      995    +1     
+ Partials      668      667    -1     
Files with missing lines Coverage Δ
...al/capture/session/SessionPropertiesServiceImpl.kt 75.00% <100.00%> (ø)
...dk/internal/config/behavior/SessionBehaviorImpl.kt 75.00% <100.00%> (ø)
...android/embracesdk/internal/utils/PropertyUtils.kt 100.00% <100.00%> (+16.66%) ⬆️
...oid/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt 100.00% <100.00%> (ø)
...nal/config/instrumented/schema/OtelLimitsConfig.kt 100.00% <100.00%> (ø)
...roid/embracesdk/internal/logs/EmbraceLogService.kt 90.90% <82.35%> (-2.43%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Jul 22, 2025

Merge activity

  • Jul 22, 1:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 22, 1:41 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 22, 2:05 PM UTC: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil force-pushed the hho/up-log-props-limit branch from 9ce5f40 to 0be2f5f Compare July 22, 2025 13:40
@bidetofevil bidetofevil merged commit c887ff2 into main Jul 22, 2025
12 checks passed
@bidetofevil bidetofevil deleted the hho/up-log-props-limit branch July 22, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants