Increase limit for log properties to 100#2392
Merged
bidetofevil merged 3 commits intomainfrom Jul 22, 2025
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
763965a to
9ce5f40
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
=======================================
Coverage 84.38% 84.39%
=======================================
Files 482 482
Lines 10642 10648 +6
Branches 1571 1571
=======================================
+ Hits 8980 8986 +6
- Misses 994 995 +1
+ Partials 668 667 -1
🚀 New features to boost your workflow:
|
Contributor
Author
Merge activity
|
9ce5f40 to
0be2f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Update limits for attribute key length, value length, and counts to 128, 1024, and 100, respectively. Add a cap of 200 for remote configured session prop limits as well.
PropertyUtilwas also refactored so it contains a truncation method, but the sanitization method was inlined into theEmbraceLogServiceclass because that's the only place that used it. Tests were ported too - at least the relevant ones.