Add OTel resource attributes to the embrace payload envelopes#2994
Add OTel resource attributes to the embrace payload envelopes#2994bidetofevil wants to merge 2 commits intomainfrom
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
20c7f1e to
2f46115
Compare
84a0f2f to
a2821ef
Compare
a2821ef to
714840b
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
fractalwrench
left a comment
There was a problem hiding this comment.
LGTM assuming payload schema has been agreed with backend folks
...integrationTest/kotlin/io/embrace/android/embracesdk/testcases/session/SessionPayloadTest.kt
Show resolved
Hide resolved
|
I'm not going to merge this until I confirm whether the keys with |
| else -> "$path.$key" | ||
| } | ||
| if (expectedValue == IGNORE_VALUE) { | ||
| findMissingKeys = false |
There was a problem hiding this comment.
I got the logic wrong and this breaks the missing key diffing mechanism. I'll need to fix the test some other way if we keep the current serialization form.
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days. |
def65bc to
0b40c2a
Compare
0b40c2a to
8191694
Compare
8191694 to
fa77f16
Compare
e876b22 to
52dc90a
Compare
fa77f16 to
cfe1399
Compare
cfe1399 to
4177865
Compare
4177865 to
46441f5
Compare
46441f5 to
6f02d83
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2994 +/- ##
==========================================
- Coverage 77.78% 77.77% -0.02%
==========================================
Files 553 553
Lines 11801 11809 +8
Branches 1745 1745
==========================================
+ Hits 9179 9184 +5
- Misses 1919 1921 +2
- Partials 703 704 +1
🚀 New features to boost your workflow:
|
6f02d83 to
ccafd16
Compare
|
The |
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days. |

Goal
Add OTel resource attributes to the Embrace payload envelope
resourceobject