Skip to content

Add OTel resource attributes to the embrace payload envelopes#2994

Open
bidetofevil wants to merge 2 commits intomainfrom
hho/otel-resource-in-envelope
Open

Add OTel resource attributes to the embrace payload envelopes#2994
bidetofevil wants to merge 2 commits intomainfrom
hho/otel-resource-in-envelope

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Jan 7, 2026

Goal

Add OTel resource attributes to the Embrace payload envelope resource object

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Jan 7, 2026

@bidetofevil bidetofevil marked this pull request as ready for review January 7, 2026 15:49
@bidetofevil bidetofevil requested a review from a team as a code owner January 7, 2026 15:49
@bidetofevil bidetofevil changed the base branch from hho/rename-internal-logger to graphite-base/2994 January 7, 2026 15:51
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from 84a0f2f to a2821ef Compare January 7, 2026 15:53
@graphite-app graphite-app bot changed the base branch from graphite-base/2994 to main January 7, 2026 15:54
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from a2821ef to 714840b Compare January 7, 2026 15:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming payload schema has been agreed with backend folks

Copy link
Copy Markdown
Contributor Author

I'm not going to merge this until I confirm whether the keys with . will cause a problem for parsing on the backend and whether we should put it in extras or otel - I prefer the latter tbh.

else -> "$path.$key"
}
if (expectedValue == IGNORE_VALUE) {
findMissingKeys = false
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the logic wrong and this breaks the missing key diffing mechanism. I'll need to fix the test some other way if we keep the current serialization form.

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

@github-actions github-actions bot added the stale label Jan 28, 2026
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from def65bc to 0b40c2a Compare January 28, 2026 22:31
@bidetofevil bidetofevil removed the stale label Jan 29, 2026
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from 0b40c2a to 8191694 Compare January 30, 2026 17:37
@bidetofevil bidetofevil changed the base branch from main to graphite-base/2994 January 30, 2026 23:38
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from 8191694 to fa77f16 Compare January 30, 2026 23:38
@bidetofevil bidetofevil changed the base branch from graphite-base/2994 to hho/sample-app-tweak January 30, 2026 23:39
@bidetofevil bidetofevil changed the base branch from hho/sample-app-tweak to graphite-base/2994 February 2, 2026 15:56
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from fa77f16 to cfe1399 Compare February 2, 2026 15:58
@graphite-app graphite-app bot changed the base branch from graphite-base/2994 to main February 2, 2026 15:59
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from cfe1399 to 4177865 Compare February 2, 2026 15:59
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from 4177865 to 46441f5 Compare February 9, 2026 18:56
@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from 46441f5 to 6f02d83 Compare February 19, 2026 14:24
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.77%. Comparing base (30f1f6b) to head (ccafd16).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2994      +/-   ##
==========================================
- Coverage   77.78%   77.77%   -0.02%     
==========================================
  Files         553      553              
  Lines       11801    11809       +8     
  Branches     1745     1745              
==========================================
+ Hits         9179     9184       +5     
- Misses       1919     1921       +2     
- Partials      703      704       +1     
Files with missing lines Coverage Δ
...esdk/internal/injection/PayloadSourceModuleImpl.kt 97.53% <100.00%> (+0.12%) ⬆️
...al/envelope/resource/EnvelopeResourceSourceImpl.kt 100.00% <100.00%> (ø)
...d/embracesdk/internal/otel/config/OtelSdkConfig.kt 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bidetofevil bidetofevil force-pushed the hho/otel-resource-in-envelope branch from 6f02d83 to ccafd16 Compare March 11, 2026 04:45
Copy link
Copy Markdown
Contributor Author

The . keys are fine. I will find a way to test this better and get this reviewed again

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this PR will be closed in 10 days.

@github-actions github-actions bot added the stale label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants