Skip to content

Refactor navigation state so core is impl agnostic #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bidetofevil wants to merge 2 commits into from

Replace setters with mutable members on NavigationTrackingService

7e1c1dc
Select commit
Loading
Failed to load commit list.
Closed

Refactor navigation state so core is impl agnostic #3208

Replace setters with mutable members on NavigationTrackingService
7e1c1dc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 10, 2026 in 1s

78.24% (+0.18%) compared to 0b6e48a

View this Pull Request on Codecov

78.24% (+0.18%) compared to 0b6e48a

Details

Codecov Report

❌ Patch coverage is 92.70833% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.24%. Comparing base (0b6e48a) to head (7e1c1dc).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/navigation/NavigationTrackingServiceImpl.kt 62.50% 3 Missing ⚠️
...ntation/compose/navigation/NavControllerTracker.kt 89.28% 0 Missing and 3 partials ⚠️
...nstrumentation/navigation/NavigationEventBroker.kt 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
+ Coverage   78.06%   78.24%   +0.18%     
==========================================
  Files         579      586       +7     
  Lines       12098    12218     +120     
  Branches     1815     1837      +22     
==========================================
+ Hits         9444     9560     +116     
+ Misses       1933     1931       -2     
- Partials      721      727       +6
Files with missing lines Coverage Δ
...oid/embracesdk/internal/InstrumentationArgsImpl.kt 86.66% <100.00%> (+0.45%) ⬆️
...k/internal/injection/EssentialServiceModuleImpl.kt 70.45% <100.00%> (+1.40%) ⬆️
...dk/internal/injection/InstrumentationModuleImpl.kt 100.00% <100.00%> (ø)
...d/embracesdk/internal/logging/InternalErrorType.kt 100.00% <100.00%> (ø)
.../arch/navigation/NavigationTrackingInitListener.kt 100.00% <100.00%> (ø)
...gation/ComposeNavigationInstrumentationProvider.kt 100.00% <100.00%> (ø)
...umentation/navigation/ActivityNavigationTracker.kt 74.07% <100.00%> (+2.07%) ⬆️
...rnal/instrumentation/navigation/NavigationEvent.kt 76.31% <100.00%> (+5.34%) ⬆️
...umentation/navigation/NavigationStateDataSource.kt 95.00% <100.00%> (+2.14%) ⬆️
...vigation/NavigationStateInstrumentationProvider.kt 100.00% <ø> (ø)
... and 3 more

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov