Fix iOS and Android SDK limits in documentation#709
Open
nelsitoPuglisi wants to merge 2 commits intomainfrom
Open
Fix iOS and Android SDK limits in documentation#709nelsitoPuglisi wants to merge 2 commits intomainfrom
nelsitoPuglisi wants to merge 2 commits intomainfrom
Conversation
Corrected limits verified against embrace-android-sdk source: - shared/log-limit.md: properties per log 10→100 (MAX_PROPERTY_COUNT), property value length 256→1024 (MAX_PROPERTY_VALUE_LENGTH) - shared/property-limit.md: property value length 256→1024 (SESSION_PROPERTY_VALUE_LIMIT) Note: traces.md limits were already correct in main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary - Markdown Lint |
Summary - Link Checker
|
Corrected limits verified against embrace-apple-sdk source: logs.md: - Log message size: "10,000 bytes" → "4,000 characters" (LengthOfBodyValidator.allowedCharacterCount = 0...4000) - Log batch time between: 2s → 20s (maximumTimeBetweenLogsInSeconds) - Log batch lifetime: 5s → 60s (LogBatchLimits.maxBatchAge) - Logs per batch: 50 → 20 (LogController.maxLogsPerBatch) traces-spans.md (Naming Conventions section): - Span name max length: 50 → 128 characters (EmbraceSpanProcessor.nameLengthLimit) - Removed unverified 50-char limit from Key Names convention Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nelsitoPuglisi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrected limit values in documentation that were outdated compared to the actual SDK implementations. Values were verified against
embrace-android-sdkandembrace-apple-sdksource code.Android changes (
shared/components)shared/log-limit.mdEmbraceLogService.MAX_PROPERTY_COUNTshared/log-limit.mdEmbraceLogService.MAX_PROPERTY_VALUE_LENGTHshared/property-limit.mdSessionPropertiesServiceImpl.SESSION_PROPERTY_VALUE_LIMITShared components used by:
integration-advanced/log-message-api,features/log-message-api,features/session-properties,features/momentsiOS 6x changes
docs/ios/6x/core-concepts/logs.mdLengthOfBodyValidator.allowedCharacterCountdocs/ios/6x/core-concepts/logs.mdDefaultEmbraceLoggerConfig.maximumTimeBetweenLogsInSecondsdocs/ios/6x/core-concepts/logs.mdLogBatchLimits.maxBatchAgedocs/ios/6x/core-concepts/logs.mdLogController.maxLogsPerBatchdocs/ios/6x/core-concepts/traces-spans.mdEmbraceSpanProcessor.nameLengthLimitdocs/ios/6x/core-concepts/traces-spans.mdNote: the Naming Conventions section in
traces-spans.mdwas contradicting its own Trace Limits table (which already said 128 characters correctly).Test plan
features/log-message-api,integration-advanced/log-message-api,features/session-properties,features/momentscore-concepts/logs,core-concepts/traces-spans🤖 Generated with Claude Code