Skip to content

Revert Android log limits to shared component and fix iOS max log length#731

Open
nelsitoPuglisi wants to merge 1 commit intomainfrom
fix/log-limits-use-shared-component
Open

Revert Android log limits to shared component and fix iOS max log length#731
nelsitoPuglisi wants to merge 1 commit intomainfrom
fix/log-limits-use-shared-component

Conversation

@nelsitoPuglisi
Copy link
Contributor

Summary

  • Android pages: revert inline log limits back to using shared/log-limit.md, since the effective max message length is 4,000 for all platforms via remote config (app-service always returns LOG_MAX_LENGTH_MAX_VALUE = 4000)
  • iOS 6x logs: fix incorrect "10,000 bytes" to "4,000 characters"
  • shared/log-limit.md already had the correct value (4,000)

Supersedes #730 (closed due to messy commit history).
Reverts the Android-specific inlining from #727.

Test plan

  • Verify Android log-message-api pages render the shared log-limit warning correctly
  • Verify iOS 6x logs page shows "4,000 characters" instead of "10,000 bytes"
  • Confirm shared/log-limit.md consumers (Flutter, RN, Unity, iOS 5x) still work

🤖 Generated with Claude Code

- Android pages: revert to using shared/log-limit.md since the effective
  max message length is 4000 for all platforms via remote config
- iOS 6x logs: fix incorrect "10,000 bytes" to "4,000 characters"

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nelsitoPuglisi nelsitoPuglisi requested review from a team as code owners March 10, 2026 19:55
@github-actions
Copy link

Summary - Link Checker

Status Count
🔍 Total 478
✅ Successful 382
⏳ Timeouts 0
🔀 Redirected 1
👻 Excluded 95
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Redirects per input

Redirects in docs/data-destinations/honeycomb.md

@github-actions
Copy link

Summary - Markdown Lint

Success: No issues found in 393 files (122ms)

@nelsitoPuglisi nelsitoPuglisi marked this pull request as draft March 10, 2026 19:56
@nelsitoPuglisi nelsitoPuglisi marked this pull request as ready for review March 10, 2026 20:05
Copy link
Contributor

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants