Open
Conversation
Removed calls to Log Unity Exception on the shared unity internal instance and instead am calling the the embrace shared instance's log message directly.
Contributor
Author
|
Unfortunately this is currently blocked by being unable to access the logging methods that can accept an UNHANDLED or HANDLED enum. @bidetofevil and I are talking about creating a public function specifically for handling these types of exceptions from the hosted SDKs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed calls to Log Unity Exception on the shared unity internal instance and instead am calling the the embrace shared instance's log message directly.
Goal
Long term goal is to clean up the native SDKs as much as possible in regards to have specific Engine/framework level calls. This specific PR removes the need for handling unity exceptions explicitly and instead sets up the Unity SDK to call the Native SDK functions directly
Testing
Automated + Device Testing
Release Notes
Updated the Embrace Android implementation to call the Android Native SDK directly via LogMessage instead of a special Unity interface that was setup
WHAT:
WHY:
WHO:Ben Bennett