Add missing .gitignores to better support --addon-only scenarios (no test app) #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Feb 12, 2024
| @@ -5,8 +5,13 @@ | |||
| /LICENSE.md | |||
There was a problem hiding this comment.
a gitignore file (especially this one) must not assume a parent gitignore exists.
NullVoxPopuli
commented
Feb 12, 2024
| @@ -85,8 +85,8 @@ for (let packageManager of SUPPORTED_PACKAGE_MANAGERS) { | |||
| "index.js", | |||
| "index.js.map", | |||
| "services", | |||
| "template-only-dYTzhOEA.js", | |||
There was a problem hiding this comment.
inconsequential snapshot update - likely due to a floating dep change
simonihmig
approved these changes
Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using
--addon-onlya lot lately (no test-app, only generates the addon),and noticed that some .gitignore entries were missing.
To protect silly files from accidentally getting committed to git, I've added more entries to the .gitignore.
My use case is likely not my own, but also we want to actually support a non-monorepo layout eventually anyway, so this progresses us towards that as well.
atm, it looks likemainis broken: https://github.com/embroider-build/addon-blueprint/actions/runs/7864883532But: ember-cli/ember-cli#10443
But also: platinumazure/eslint-plugin-qunit#478