Enable bugfixes: true to Babel's config - #584
Conversation
|
Thanks, this seems like a good idea, and from reading the description of the I think the test failures here are happening because some of the stuff being left un-transpiled now doesn't work in the node version we're testing under. It may be that we just need to add node to the targets for those test cases. |
1 similar comment
|
Thanks, this seems like a good idea, and from reading the description of the I think the test failures here are happening because some of the stuff being left un-transpiled now doesn't work in the node version we're testing under. It may be that we just need to add node to the targets for those test cases. |
|
@ef4 thanks for the review! Do you want me to do it or are you? I'll need a pointer or two if it's going to be me - what should be changed and where. 😄 |
That leads to (much) smaller code and will be the default in Babel 8. I got to that because my
targetscontainssafari >= 16but due to this code was transpiled for much older browsers. I fixed the problem for classic packages in Ember (by addingbugfixes: truetobabelinember-cli-build.js) but forember-auto-imported ones I couldn't - this flag is needed for them.@ef4 have I done the correct thing here?