Fix importing absolutely aliased dependency - #641
Open
simonihmig wants to merge 2 commits into
Open
Conversation
simonihmig
changed the title
simonihmig
force-pushed
the
fix-absolute-alias
branch
from
October 7, 2024 11:33
df376fa to
ac316b3
Compare
simonihmig
marked this pull request as ready for review
October 7, 2024 12:45
ef4
reviewed
Oct 8, 2024
|
|
||
| if (packageName) { | ||
| let packageRoot: string | undefined; | ||
| let packagePath = resolvePackagePath(packageName, this.root); |
Collaborator
There was a problem hiding this comment.
I would be concerned here that if we support aliasing to absolute paths, it should not be mandatory that the package resolves at all.
Comment on lines
+344
to
+345
| packageName, | ||
| packageRoot, |
Collaborator
There was a problem hiding this comment.
Perhaps we can alter the types so that in the case of an absolute resolution these are not present. I don't know what the downstream effects of that would be, but they're extremely relevant to this PR, since this PR would be giving that code potentially misleading information. (Nothing enforces that the absolute path is actually coming from this packageName and packageRoot.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #616