Skip to content

Add highlight and text colour marks, or a seam to register one #2473

Description

@virafb

@emdash-cms/admin@0.33.0 registers a fixed inline mark set in src/components/PortableTextEditor.tsx: bold, italic, underline, strike, code, link, subscript, superscript. Highlight and text colour are absent, and @tiptap/starter-kit@3.29.2 does not bundle extension-highlight, -text-style or -color.

They can't be added downstream. Per #2430 there is no plugin seam to register a TipTap mark, and read-back conversion drops unknown marks. Note #2430 cites the core package's converters; @emdash-cms/admin has its own copy — convertPTMarks (line 1281) drops any bare unknown mark — so fixing core alone won't fix the admin editor.

Ask: add Highlight and TextStyle/Color to the built-in set, or ship the seam proposed in #1996/#144 and preserve registered custom marks on read-back.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions