auto-seed overwrites live site settings (site:title) when seed.json changes

[het-labo]

applySeed applies seed.settings unconditionally
(seed/apply.ts ~155: settings are written even with
onConflict: "skip"). On a live site whose seed file evolves (template
development, adding a field via emdash seed --on-conflict update),
every boot resets site:title/site:tagline to the seed values,
silently discarding what the admin configured. Expected: settings are
seed-once (like content with skip), or an explicit opt-in flag.

---

Found while building a multilingual client-site starter on EmDash 0.30.0 (Astro 7, Node standalone).

[ascorbic]

@emdashbot fix

[emdashbot]

Failed

Fix applySeed to respect onConflict for site settings so live sites don't lose admin-configured title/tagline on re-seed.

• Inspect seed/apply.ts and settings storage
• Implement onConflict-aware settings application
• Add focused tests for settings skip/update/error
• Run lint, typecheck, and seed tests
• Publish candidate and report — blocked

Outcome: Implemented the fix but could not publish the candidate branch due to a 403 from GitHub.

What changed:

• packages/core/src/seed/apply.ts: site settings now respect `onConflict`. Under `skip` (the runtime default) they are seed-once: if any seeded site:* key already exists, the whole settings block is skipped so admin-configured `site:title`/`site:tagline` survive re-seeding. `update` still overwrites, and `error` throws when any seeded setting exists.
• packages/core/tests/unit/seed/apply.test.ts: added tests for skip (preserves admin changes), update (overwrites), and error (throws).
• .changeset/seed-settings-skip-once.md: patch changeset for `emdash`.

Verification all passed:

• pnpm lint:quick — clean (0 diagnostics)
• pnpm typecheck — clean
• pnpm format:check — clean
• pnpm vitest run tests/unit/seed/apply.test.ts — 48 passed
• pnpm vitest run tests/unit/seed tests/integration/seed-on-conflict.test.ts tests/integration/seed-live-revisions.test.ts tests/integration/seed-i18n-default-locale.test.ts tests/integration/i18n/i18n.test.ts — 213 passed

Publication failure:

• publish_candidate repeatedly returned: `error: RPC failed; HTTP 403 curl 22 The requested URL returned error: 403`
• Manual `git push` to both the candidate branch name and a test branch produced the same 403.
• `curl -H "Authorization: Bearer <token>" https://api.github.com/user\` returned 401, while `.../repos/emdash-cms/emdash` returned 200, suggesting the configured token has repo read but not write access.

The fix is ready in the local workspace; publication is blocked by the push credential/policy, so I am reporting without implemented=true as required.

candidate push failed: error: RPC failed; HTTP 403 curl 22 The requested URL returned error: 403 send-pack: unexpected disconnect while reading sideband packet fatal: the remote end hung up unexpectedly

Failed stage: publication

Mode: implement

View live dashboard · Run: f95af4cd-39ab-4422-872f-93d6baabb2eb

[ascorbic]

@emdashbot retry

[emdashbot]

Completed

Make applySeed respect onConflict for site settings so live admin changes to site:title/tagline survive re-seeding under the default skip mode.

• Inspect seed apply, settings storage, and existing tests
• Apply onConflict to site settings in applySeed
• Add regression tests for skip/update/error settings behavior
• Run focused tests, lint, typecheck, and format
• Add patch changeset for emdash
• Publish candidate and report

Outcome: Fixed `applySeed` so site settings respect `onConflict` instead of being overwritten unconditionally.

Changes:

• `packages/core/src/seed/apply.ts`: Added `applySiteSettings()`, which checks existing `site:*` keys before writing. In the default `skip` mode, the whole settings block is skipped when any seeded key already exists (`result.settings.applied` stays 0), protecting admin changes to `site:title`/`site:tagline`. `update` overwrites settings, and `error` throws a conflict with the first conflicting prefixed key.
• `packages/core/tests/unit/seed/apply.test.ts`: Added three regression tests covering skip (preserves admin title, does not add missing seeded keys), update (overwrites and adds keys), and error (throws with the conflicting setting name).
• `.changeset/seed-settings-skip-once.md`: Patch changeset for `emdash`.

Verification:

• `pnpm vitest run tests/unit/seed/apply.test.ts` — 48 passed
• `pnpm vitest run tests/unit/seed tests/integration/seed-on-conflict.test.ts tests/integration/seed-live-revisions.test.ts tests/integration/seed-i18n-default-locale.test.ts tests/integration/i18n/i18n.test.ts` — 213 passed
• `pnpm lint:quick` — clean
• `pnpm typecheck` — clean
• `pnpm format:check` — clean

Candidate published to `bot/fix-2693` (commit `caef3599fb5aab99e6afd0cd064a555874f8671b`).

Mode: implement

View live dashboard · Run: 3c6ae6ce-c318-4a4b-8ee5-1c174c9a1dd2

[emdashbot]

A candidate change is ready to preview.

Fixed applySeed so site settings respect onConflict instead of being overwritten unconditionally.

Changes:

• packages/core/src/seed/apply.ts: Added applySiteSettings(), which checks existing site:* keys before writing. In the default skip mode, the whole settings block is skipped when any seeded key already exists (result.settings.applied stays 0), protecting admin changes to site:title/site:tagline. update overwrites settings, and error throws a conflict with the first conflicting prefixed key.
• packages/core/tests/unit/seed/apply.test.ts: Added three regression tests covering skip (preserves admin title, does not add missing seeded keys), update (overwrites and adds keys), and error (throws with the conflicting setting name).
• .changeset/seed-settings-skip-once.md: Patch changeset for emdash.

Verification:

• pnpm vitest run tests/unit/seed/apply.test.ts — 48 passed
• pnpm vitest run tests/unit/seed tests/integration/seed-on-conflict.test.ts tests/integration/seed-live-revisions.test.ts tests/integration/seed-i18n-default-locale.test.ts tests/integration/i18n/i18n.test.ts — 213 passed
• pnpm lint:quick — clean
• pnpm typecheck — clean
• pnpm format:check — clean

Candidate published to bot/fix-2693 (commit caef3599fb5aab99e6afd0cd064a555874f8671b).

Try the change against your own site:

npm i https://pkg.pr.new/emdash@bot/fix-2693

Or try the candidate in a ready-to-use playground:

Open the playground preview

@het-labo could you try this? Reply naturally to say whether it works or explain what still needs to change.

_{A maintainer can accept on the reporter's behalf. Acceptance opens a draft PR; requested changes start another candidate revision.}

Fix branch: bot/fix-2693 · Artifacts branch: bot/artifacts-2693