i18n(zh-TW): complete Traditional Chinese translations - #2189
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
🦋 Changeset detectedLatest commit: 8794e7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Scope checkThis PR changes 3,374 lines across 1 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
This translation-only PR is the right change for the right problem: it completes the zh-TW admin catalog for an already-enabled locale, and it touches nothing else.
I statically reviewed the changed .po file and the repo conventions. The good news: only packages/admin/src/locales/zh-TW/messages.po is modified, message IDs/source references/catalog order are preserved, there are no fuzzy entries, no obsolete entries, and every entry is translated. I also parsed the file and verified that ICU placeholder variables (including plural/select arguments) and Lingui JSX tags are preserved in every translation, with no missing or extra placeholders. Leading/trailing whitespace matches the source strings.
One convention gap remains: @emdash-cms/admin is a published package and is not in .changeset/config.json's ignore list. Per CONTRIBUTING.md, "Every PR that changes a published package's behavior needs a changeset," and translation PRs are not in the listed exceptions (docs-only/test-only/CI/tooling/demos/templates). This PR should include a patch changeset for @emdash-cms/admin. That's a quick fix (pnpm changeset), but it should be added before merge so the release pipeline picks up the new translations.
Overall: structurally sound, just missing the required changeset.
| @@ -15,61 +15,61 @@ msgstr "" | |||
|
|
|||
| #: packages/admin/src/routes/bylines.tsx:446 | |||
| msgid " - Guest" | |||
| msgstr "" | |||
| msgstr " - 訪客" | |||
There was a problem hiding this comment.
[needs fixing] This PR updates 1,932 user-facing strings in a published package (@emdash-cms/admin), so CONTRIBUTING.md requires a changeset. Translation-only PRs are not in the changeset-exempt categories listed in CONTRIBUTING.md, and @emdash-cms/admin is not in .changeset/config.json's ignore list.
Please add a patch changeset for @emdash-cms/admin:
pnpm changesetThen create .changeset/<name>.md with something like:
---
"@emdash-cms/admin": patch
---
Completes the Traditional Chinese (zh-TW) translation of the admin interface.This ensures the release pipeline versions the package and includes the translation in the changelog.
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
What does this PR do?
Completes the Traditional Chinese (
zh-TW) translation of the EmDash admin interface.This update:
zh-TWmessage catalog.Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
The catalog passes GNU gettext validation: