fix(core): separate revision author from entry owner and pass actor to content hooks (#2881) - #3057
Merged
Conversation
…o content hooks (#2881) EmDash-Run: 806a2348-849c-4be2-9529-757229e5c2a7
🦋 Changeset detectedLatest commit: 29b53ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://bot-fix-2881.try.emdashcms.com, https://bot-fix-2881-emdash-playground.emdash-cms.workers.dev (commit 29b53ff)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
17 tasks
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-moderation
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
ascorbic
marked this pull request as ready for review
September 10, 2026 22:35
Contributor
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 29b53ff | Sep 11 2026, 11:35 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes content change attribution so revisions, entry ownership, and hook payloads no longer conflate the acting user.
content_updatenow pass the authenticated actor separately from the entry owner.revisions.author_idis set from the actor when the client does not supply one, so admin saves stop recordingNULLauthors.authorIdoncontent_updatechanges onlyec_{collection}.author_id; the MCP no longer silently reassigns entry ownership on every edit.content:beforeSaveandcontent:afterSavehooks now receiveevent.actorwith the acting user'sidandrole.actoris treated as draft-only metadata, so authenticated draft saves that only supply actor metadata do not bump the content version or invalidate public caches.packages/core/tests/integration/content/attribution-2881.test.ts.Closes #2881.
A candidate change the reporter confirmed against their own site via the preview build:
Opened automatically by emdashbot as a draft. A maintainer must review before merge.
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output