Skip to content

fix(admin): do not exit distraction-free mode with Escape (#3116) - #3125

Merged
ascorbic merged 1 commit into
mainfrom
bot/fix-3116
Sep 15, 2026
Merged

ascorbic merged 1 commit into
mainfrom
bot/fix-3116

Conversation

@emdashbot

@emdashbot emdashbot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes the document-level Escape handler from the admin content editor's distraction-free mode so that Escape remains free for other actions on the Posts page. The advertised ⌘⇧\ shortcut and the explicit exit button still toggle the mode.

  • Removes the Escape capture listener in ContentEditor.tsx.
  • Flips the regression test to assert Escape does not exit distraction-free mode.
  • Updates the existing mobile block-panel test to exit via the explicit button.
  • Updates the changeset.

Closes #3116.

A candidate change the reporter confirmed against their own site via the preview build:

npm i https://pkg.pr.new/emdash@bot/fix-3116

Opened automatically by emdashbot as a draft. A maintainer must review before merge.

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added and reviewed the user-facing changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...
  • I have included screenshots below if this PR changes the UI

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool: emdashbot + Kimi K2.7 Code

Screenshots / test output

EmDash-Run: 933d928f-c567-42e9-b4ee-d20c08e0e2ca
@changeset-bot

changeset-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4f5ba4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/plugin-test Patch
@emdash-cms/sandbox-workerd Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
create-emdash Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
@emdash-cms/auth-atproto Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@3125

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@3125

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@3125

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@3125

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@3125

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@3125

emdash

npm i https://pkg.pr.new/emdash@3125

create-emdash

npm i https://pkg.pr.new/create-emdash@3125

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@3125

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@3125

@emdash-cms/plugin-test

npm i https://pkg.pr.new/@emdash-cms/plugin-test@3125

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@3125

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@3125

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@3125

@emdash-cms/registry-moderation

npm i https://pkg.pr.new/@emdash-cms/registry-moderation@3125

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@3125

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@3125

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@3125

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@3125

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@3125

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@3125

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@3125

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@3125

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@3125

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@3125

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@3125

commit: 4f5ba4e

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://bot-fix-3116.try.emdashcms.com, https://bot-fix-3116-emdash-playground.emdash-cms.workers.dev (commit 4f5ba4e)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://1fb770e8.try.emdashcms.com, https://1fb770e8-emdash-playground.emdash-cms.workers.dev 4f5ba4e 2026-09-15T12:25:51.344Z Visit the dashboard ↗

@ascorbic
ascorbic marked this pull request as ready for review September 15, 2026 17:41
@ascorbic
ascorbic merged commit c783951 into main Sep 15, 2026
56 checks passed
@ascorbic
ascorbic deleted the bot/fix-3116 branch September 15, 2026 18:23
@emdashbot emdashbot Bot mentioned this pull request Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: Distraction-free mode cannot toggle with combo keys

1 participant