language extension to the mailer#50
Open
felarov wants to merge 4 commits into
Open
Conversation
models : extension of the model with language code admin : changes to make the models editable mailer : changes to push the language versions in the content of the mails p.s. a template has to be made for each language version of link_site and unsubscribe templates(fall back available)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made straigthforward changes to the code.
models : extended for translations and adapted the admin
mailer : use the translations in the mail creation. I propose to take a different template for the different languages for the newsletter_link_unsubscribe.html. The legal requirements vary in every country so that a trans template tag would propably not be enough.
I would like to add newsletter templates per newsletter. the body_insertion routine seems to be a good starting point, alternatively extension of the context and a {% extends %} template tag.