webdav: ConditionalMatch with multiple etags #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkyq
commented
Jan 13, 2025
| // | ||
| // The function returns early if no ETags are set (isSet is false) or if a wildcard (*) is used, | ||
| // in which case all ETags match. For multiple ETags, it checks each one until a match is found or all are checked. | ||
| func (val ConditionalMatch) MatchETag(etag string) (isSet bool, match bool, err error) { |
Author
There was a problem hiding this comment.
rationale for returning isSet
the MatchETag function should check whether val.IsSet() is non-nil, otherwise it leads to the wrong behaviour.
this seemed the only reasonable solution (beyond implementors inspecting error types), and reduces boilerplate code for implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#117