Skip to content

Allow parse etag without quotes #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LugaMuga wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow parse etag without quotes #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82e82be
- Allow parse etag without quotes
LugaMuga Apr 18, 2022
c9b61c2
- Return etag "as is"
LugaMuga May 3, 2022
ae6a4e5
- Remove UnmarshalText, MarshalText, String methods for eTag
LugaMuga May 4, 2022
4e68d10
Merge branch 'master' into make-etag-parse-not-so-strictly
LugaMuga Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@

# Project-local glide cache, RE: https://github.com/Masterminds/glide/issues/736
.glide/
Copy link
Owner

@emersion emersion May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change this file

Copy link
Author

@LugaMuga LugaMuga May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Author

@LugaMuga LugaMuga May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted all changes


# JetBrains GoLand
.idea
*.iml
*.ipr
Copy link
Owner

@emersion emersion Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit editor-specific ignore rules.

Copy link
Author

@LugaMuga LugaMuga Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will remove it.

3 changes: 2 additions & 1 deletion internal/elements.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ type ETag string
func (etag *ETag) UnmarshalText(b []byte) error {
Copy link
Owner

@emersion emersion May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is now a no-op and can be dropped.

Copy link
Author

@LugaMuga LugaMuga May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Author

@LugaMuga LugaMuga May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

s, err := strconv.Unquote(string(b))
if err != nil {
return fmt.Errorf("webdav: failed to unquote ETag: %v", err)
*etag = ETag(b)
Copy link
Owner

@emersion emersion Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this completely ignores all errors. Not sure this is a great idea.

Copy link
Author

@LugaMuga LugaMuga Apr 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. But how we can logged error with warn status?

return nil
}
*etag = ETag(s)
return nil
Expand Down