Add option flag to support re-selecting until Return key is pressed #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump? This is a life safer for me. |
|
Ohh there's a PR for this!! Awesome! But why the holdup? 2023.. what's missing before it can be merged? |
tmccombs
requested changes
Sep 5, 2025
| uint32_t time, wl_fixed_t surface_x, wl_fixed_t surface_y) { | ||
| struct slurp_seat *seat = data; | ||
| // the places the cursor moved away from are also dirty | ||
| if (seat->pointer_selection.has_selection) { |
| } | ||
| break; | ||
|
|
||
| case XKB_KEY_Return: |
Collaborator
There was a problem hiding this comment.
What if return is hit while you are currently dragging a selection? Should we then store the current selection in the result?
|
|
||
| case WL_KEYBOARD_KEY_STATE_RELEASED: | ||
| if (keysym == XKB_KEY_space) { | ||
| switch (keysym) { |
Collaborator
There was a problem hiding this comment.
This isn't necessarily a bad change, but it seems unrelated to the rest of this PR
Co-authored-by: Thayne McCombs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-Cwhich prevents slurp from exiting immediately once the rectangle drag is released. The rectangle may be re-selected, and selection is ended by pressing the Return key. The intent of this feature is to enable users to redo a selection if the first attempt was unsatisfactory.