payments: update Wise implementation to match API changes #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
changed the title
russss
reviewed
Aug 30, 2025
apps/payments/wise.py
Outdated
| account.bankDetails.bankAddress.country, | ||
| ] | ||
| ) | ||
| bank_name, _, bank_address = bank_info.partition("\n") |
Member
There was a problem hiding this comment.
This feels like it might come back to bite us at some point - perhaps we should remove the institution column from BankAccount and just throw this all in the address field.
Contributor
Author
There was a problem hiding this comment.
Yep, this does seem fragile. However: it does seem useful in the admin UI (and perhaps elsewhere?) to have a small descriptive text field with the institution name alone.
I'll think about it some more. Another option could be to add validation logic so that we detect any likely breakage early.
jayaddison
force-pushed
the
issue-1844/wise-api-updates
branch
from
8040734 to
4cbf020
Compare
jayaddison
commented
Sep 9, 2025
jayaddison
commented
Sep 9, 2025
jayaddison
commented
Sep 9, 2025
NB: Redacts a few Cloudflare/Envoy, cookie, etc-related response headers
…bles/attributes Relates-to commit 559cc5d.
Relates-to commit 0c469bd.
jayaddison
force-pushed
the
issue-1844/wise-api-updates
branch
from
ab1a647 to
4bba914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1844, the Wise API has been updated and we need to update our codebase accordingly.
An open question is whether our
BankAccountrecords for Wise accounts should use the same account-per-currency design model as our Stripe accounts. Currently, they still do, but I would like to explore whether it would make sense to consolidate to a single account ID (on which we could, for example, populate all of sort-code, account-number, SWIFT and IBAN).Creating this pull request as a draft, initially.
Resolves #1844.