Village long description #1863
Open
Village long description #1863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
us-east-1 detected |
wlcx
requested changes
Oct 20, 2025
Member
wlcx
left a comment
wlcx
left a comment
There was a problem hiding this comment.
I know this is partially a draft PR, sorry if you already had any of these on your list!
- Looks like the migration needs "rebasing" onto the newest HEAD migration.
- My humble request would be for new code to have type annotations. Very happy to help if there's any mypy gnarliness.
- From a UX perspective I think we should state the markdown limitations (i.e. images disabled) in the form.
I'll leave the security considerations to someone with more experience in that area 😅
| <a href="{{ village.map_link }}">📍 Map</a> | ||
| {% endif %} | ||
|
|
||
| {# TODO: Can we show what's on at the village venues here? #} |
Member
There was a problem hiding this comment.
I was going to say that I'm not sure whether there's a link between Venue and Village, but on closer look Venue has a village_id field :)
@SamLR is this planned to still be the case?
ashirley
force-pushed
the
village-long-description
branch
from
ad00281 to
8b17a7b
Compare
ashirley
force-pushed
the
village-long-description
branch
from
8b17a7b to
3ad70e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still a lot to tidy up here but wanted to get some opinions sooner rather than later about iFrame layout options
Add a long_description field to villages. This is markdown from untrusted users and is rendered using nh3 and a sandboxed iFrame in order to limit the untrusted HTML.
There are 2 layout options for the iFrame:
The first uses javascript to resize the iFrame to prevent scrolling within the iFrame.
The second uses a static size for the iFrame which scrolls for long content.
The advantage of the second is that we can remove the allow-scripts privilege from the iFrame.
fixes #1816