Conversation
From a usability point of view, I would change it to something more explicit, maybe just a native
I would include this here, because it’s inevitable that someone is going to press the Join button not understanding what they’re doing, and they would want to leave. Fine to only join one village at a time though, it’s a bit of a physical constraint if the idea is that you camp with a village. |
Good point about mobile users. In hindsight it is trivial to add a confirmation screen so I've done that.
Added now (including deleting a village when the last person leaves and preventing the last of the admins leaving without promoting a normal member first) |
|
Thanks! from a quick scan of the code, it looks like all paths that I can think of are cover now :) |
85b8ab6 to
24ee26b
Compare
|
Thanks for doing this! I know it doesn't make much practical difference, but I think we do need an approval step before someone can join a village. There are plenty of villages which aren't really open membership, and I think it will give people the wrong impression if they can join them without approval. I think the best way of doing this is to create a |
|
Makes sense. Do you think villages should be able to choose to be open-membership if they want (to cut down admin and encourage people joining)? Also, I assume you can only request membership of one village at a time (and can't request to join if you're already a member of another etc). |
I think if the button says "Request to join" then that will probably be enough discouragement for the moment. I don't want to add more complexity than necessary, and we can always add this feature later.
Yeah, we're still saying one-village-per-person for the moment. But I guess that means that you also need to be able to withdraw a join request. |
Orga can manage non-admin members of a village, users can join a village themselves, a village-admin can promote someone who has joined their village to an admin.
This should add-up to attendees being able to self-serve giving each other access to edit the village's long_description (and other fields though these are less likely to need frequent editing)
Are the following things OK?
There is no way to remove a village admin apart from via orgaThere is no way to leave a village you have joined apart from via orga (and you can't join multiple villages) (see Add "leave village" functionality #998)this is communicated via a tooltip only (but is probably to be expected?)Fixes #1526 #845 #998