-
Notifications
You must be signed in to change notification settings - Fork 35
Update to Micropython 1.25, ESP-IDF 5.4.1 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Quickly skimming the .24 and .25 release notes for things we need to check or should take advantage of: v1.24.0To check
Interesting
v1.25.0Interesting
|
|
Annoyingly, the CI has failed to compile this. I'll look into it tomorrow. |
|
This branch should now build in CI, as a test I ran on my laptop locally seems to work. It did require removing the tildagon_usb driver, however it seems that it never did anything in the first place (let alone anything to do with USB) |
|
There's been a change to the idf where freertos.h no longer includes idf_additions.h. I think #include "freertos/idf_additions.h" should be added instead of removing the usb from the build as the dynamic usb device support that this change brings in may fix the issues with the usb branch. Also the docker pull isn't working, probably needs @MatthewWilkes to create it. |
| CONFIG_APP_EXCLUDE_PROJECT_NAME_VAR=n | ||
| CONFIG_APP_PROJECT_VER_FROM_CONFIG=y | ||
|
|
||
| CONFIG_FREERTOS_ENABLE_STATIC_TASK_CLEAN_UP=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am personally unsure on the ramifications of this change to the sdkconfig. It was required to make the compile work, and the firmware appears to behave, but I can't help but feel that this is needed somewhere.
All changes made as part of this review were to fix existing features during the upgrade rather than remove them, but no matter what I did this did not seem to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at documentation, this config setting only seems to be useful if the function vPortCleanUpTCB is defined, and as far as I am aware this project does not do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a warning when building with previous: #warning "CONFIG_FREERTOS_ENABLE_STATIC_TASK_CLEAN_UP is deprecated. Use CONFIG_FREERTOS_TASK_PRE_DELETION_HOOK instead." for mp1.25 the pre deletion hook is set to y in sdkconfig.base. I think it's right to remove the task clean up one.
|
Hm. |
Was required before mpy 1.25
|
Since this is now conflicted( I can't resolve on your branch), can it be updated to Micropython v1.26 and ESP-IDF v5.4.2? |
PR is now for Micropython v1.26 and ESP-IDF v5.4.2. I will test on a real badge shortly. |
|
Thank you! |
|
It appears that the 1.26 update doesn't work immediately, and will take time to debug the issues around it. |
|
yeah, good suggestion, thanks for trying it. |
|
Just skimmed through this and I'm unclear on the current state - does this actually work? Can we merge and upgrade to 1.25? |
As far as I'm aware it still works. I'll check it again after work |
|
We're waiting until we've done another release before merging this one. The plan is to release this in v2.0 as it breaks the mpy files used on hexpansions and we have another small break with the power supply capabilities function to go in with it. This worked when I tested it and I'm happy the todos can be marked as complete. |
|
todos are now marked complete |
Description
Updates the entire repository to use the latest stable Micropython and ESP-IDF release.
Note that free flash space decreases from 12% to 9% with this update.
Also:
scripts/hard-reset.sh, which deletes all build artifacts and returns the submodules to how they were beforescripts/firstTime.shwas run.CONFIG_FREERTOS_ENABLE_STATIC_TASK_CLEAN_UP=yfrom the sdkconfig in order to fix the compile. Need to check if this is safe.See Jonty's comment below for a quick summary of the Micropython changelogs.
Todo
CONFIG_FREERTOS_ENABLE_STATIC_TASK_CLEAN_UP=yfrom the sdkconfig, or is that integral to some part of TildagonOS? (see Update to Micropython 1.25, ESP-IDF 5.4.1 #200 (comment)) Config option was added in this commit by Matthew Wilkes, but documentation suggests it's only for if you have avPortCleanUpTCBfunction, and I don't think we do.